You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2017/04/11 13:22:56 UTC

Review Request 58353: ATLAS-1727: Mask userdetails in quick Start utility

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58353/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-1727
    https://issues.apache.org/jira/browse/ATLAS-1727


Repository: atlas


Description
-------

Bug details :- Quick Start utility requires username and password.Its better to hide the password part of it.
Used console.readPassword method of System.console to readpassword and thereby hidding the password detail.


Diffs
-----

  common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 6430fb1 


Diff: https://reviews.apache.org/r/58353/diff/1/


Testing
-------

Tested Quick start and atlas_admin.py utilities and they working fine.
Packaging going fine.


Thanks,

Nixon Rodrigues


Re: Review Request 58353: ATLAS-1727: Mask userdetails in quick Start utility

Posted by Ayub Pathan <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58353/#review171577
-----------------------------------------------------------


Ship it!




Ship It!

- Ayub Pathan


On April 11, 2017, 1:22 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58353/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 1:22 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1727
>     https://issues.apache.org/jira/browse/ATLAS-1727
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Bug details :- Quick Start utility requires username and password.Its better to hide the password part of it.
> Used console.readPassword method of System.console to readpassword and thereby hidding the password detail.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 6430fb1 
> 
> 
> Diff: https://reviews.apache.org/r/58353/diff/1/
> 
> 
> Testing
> -------
> 
> Tested Quick start and atlas_admin.py utilities and they working fine.
> Packaging going fine.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


Re: Review Request 58353: ATLAS-1727: Mask userdetails in quick Start utility

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58353/#review171578
-----------------------------------------------------------


Ship it!




Ship It!

- Apoorv Naik


On April 11, 2017, 1:22 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58353/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 1:22 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1727
>     https://issues.apache.org/jira/browse/ATLAS-1727
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Bug details :- Quick Start utility requires username and password.Its better to hide the password part of it.
> Used console.readPassword method of System.console to readpassword and thereby hidding the password detail.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 6430fb1 
> 
> 
> Diff: https://reviews.apache.org/r/58353/diff/1/
> 
> 
> Testing
> -------
> 
> Tested Quick start and atlas_admin.py utilities and they working fine.
> Packaging going fine.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>