You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2016/02/06 01:19:56 UTC

Review Request 43274: HIVE-12918 LLAP should never create embedded metastore when localizing functions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43274/
-----------------------------------------------------------

Review request for hive and Sushanth Sowmyan.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java 3ee30ed 
  hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java 0966581 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestPermsGrp.java 41c6b16 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/HCatBaseTest.java 1dbd024 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 61efc1a 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatOutputFormat.java f716da9 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitionPublish.java 5f9379b 
  hcatalog/server-extensions/src/test/java/org/apache/hive/hcatalog/listener/TestNotificationListener.java b667454 
  hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/UgiMetaStoreClientFactory.java 328b6c0 
  hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java bde78e4 
  hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingTestUtils.java e874877f 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMetrics.java ca21bb6 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 071a17e 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java bc0ad02 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 09a6aea 
  metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 2b05837 
  metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java 922a4bf 
  metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java 9c30689 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java efb50b2 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 581a919 
  ql/src/test/org/apache/hadoop/hive/metastore/TestMetastoreExpr.java 5e53604 
  ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/CompactorTest.java a929c95 

Diff: https://reviews.apache.org/r/43274/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 43274: HIVE-12918 LLAP should never create embedded metastore when localizing functions

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43274/#review118111
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2538)
<https://reviews.apache.org/r/43274/#comment179346>

    this should be removed and changed to false for now


- Sergey Shelukhin


On Feb. 6, 2016, 12:20 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43274/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2016, 12:20 a.m.)
> 
> 
> Review request for hive and Sushanth Sowmyan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 73e6c21 
>   hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java 0966581 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestPermsGrp.java 41c6b16 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 61efc1a 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatOutputFormat.java f716da9 
>   hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitionPublish.java 5f9379b 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/AbstractTestAuthorizationApiAuthorizer.java f79372d 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestEmbeddedHiveMetaStore.java b6b0e6e 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java b8cf94f 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreWithEnvironmentContext.java 8a37c11 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaTool.java 569bfd0 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMarkPartition.java 57a5e6b 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEndFunctionListener.java e2c860c 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 2f3c04b 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListenerOnlyOnCommit.java 6a14982 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreInitListener.java 42232fd 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionNameWhitelistValidation.java 61d08cd 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestRetryingHMSHandler.java e51ced7 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/StorageBasedMetastoreTestBase.java 157ce62 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestAuthorizationPreEventListener.java b8f5dd1 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestClientSideAuthorizationProvider.java 2e2da99 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMetastoreAuthorizationProvider.java 3596e30 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMultiAuthorizationPreEventListener.java 299812f 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java ce6112f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 0c30262 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 2b05837 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java 9c30689 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 75d2519 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 581a919 
>   ql/src/test/org/apache/hadoop/hive/metastore/TestMetastoreExpr.java 5e53604 
> 
> Diff: https://reviews.apache.org/r/43274/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Re: Review Request 43274: HIVE-12918 LLAP should never create embedded metastore when localizing functions

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43274/
-----------------------------------------------------------

(Updated Feb. 6, 2016, 12:20 a.m.)


Review request for hive and Sushanth Sowmyan.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 73e6c21 
  hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java 0966581 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/cli/TestPermsGrp.java 41c6b16 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 61efc1a 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatOutputFormat.java f716da9 
  hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitionPublish.java 5f9379b 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/AbstractTestAuthorizationApiAuthorizer.java f79372d 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestEmbeddedHiveMetaStore.java b6b0e6e 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java b8cf94f 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreWithEnvironmentContext.java 8a37c11 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaTool.java 569bfd0 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMarkPartition.java 57a5e6b 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEndFunctionListener.java e2c860c 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 2f3c04b 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListenerOnlyOnCommit.java 6a14982 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreInitListener.java 42232fd 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionNameWhitelistValidation.java 61d08cd 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestRetryingHMSHandler.java e51ced7 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/StorageBasedMetastoreTestBase.java 157ce62 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestAuthorizationPreEventListener.java b8f5dd1 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestClientSideAuthorizationProvider.java 2e2da99 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMetastoreAuthorizationProvider.java 3596e30 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMultiAuthorizationPreEventListener.java 299812f 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java ce6112f 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 0c30262 
  metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 2b05837 
  metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java 9c30689 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 75d2519 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 581a919 
  ql/src/test/org/apache/hadoop/hive/metastore/TestMetastoreExpr.java 5e53604 

Diff: https://reviews.apache.org/r/43274/diff/


Testing
-------


Thanks,

Sergey Shelukhin