You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by "Kevin A. McGrail" <km...@apache.org> on 2019/11/09 07:20:15 UTC
New Release Candidate: 3.4.3-rc6 Testers Needed
Good Evening Assassins,
3.4.3 release candidate 6 is now available at http://talon2.pccc.com/~kmcgrail/devel/ or http://people.apache.org/~kmcgrail/devel/
PLEASE NOTE: One of the hold-ups for releasing 3.4.3 has been finding
little bugs while testing new features. As such, we could really use
some people testing the release candidates. I am running these release
candidates in production and have no reservations recommending the same.
There are also two CVEs fixed in 3.4.3 that we will disclose more at
release so you'll definitely want to look at upgrading.
sha256sum of archive files:
a4af8f9d0caabe1934015f1832d14617ca0a91ac7251cf63f1dddb5903e7051f
Mail-SpamAssassin-3.4.3-rc6.tar.bz2
8fbeda8d1a80e61c6df4056fc73f61977b43971800fe6bd9628bf01e95083629
Mail-SpamAssassin-3.4.3-rc6.tar.gz
fff55864da8f9d198445fac2633fe30747708f9eaa409dbeddafd52b407dceb5
Mail-SpamAssassin-3.4.3-rc6.zip
2a8a55047480ed15fe23bdb24ae1158c30afb4b4dc73023b5f65c79850c9b71a
Mail-SpamAssassin-rules-3.4.3-rc6.r1869531.tgz
sha512sum of archive files:
6e220c7b047d6ff69ceff0239e3fea804d7f643b83c2c372d96f237213effaf01f761128631293300e44d9b9b51b92866db2c86ba9b73830aa74d8d11cc237d6
Mail-SpamAssassin-3.4.3-rc6.tar.bz2
12ba88818a7d799a9250262b6b78f6dc19cede9391eba18b8c4d3ccf006b31cb63acab3b0b3a1032f67b29f6421f2b0632d3c5455b4abecec2c2ea2ca508e317
Mail-SpamAssassin-3.4.3-rc6.tar.gz
ab3b6c24eb7a2f2acc7a06f8cb3093537a0dead959973aada7d9fdb3b1b3c1b5b9b1c719aa213ae0d9eeca7bd2033e99261851e0b49ec8af890dafcc6f0a0259
Mail-SpamAssassin-3.4.3-rc6.zip
01941f730de0dc40baf2b59fcafcfabc61308b6fc9f8dda6d9daaf8745915bafc42e3f575a705e70a50792df2fc6915c3a27a4b0fbf368b175152298d4228893
Mail-SpamAssassin-rules-3.4.3-rc6.r1869531.tgz
Regards,
KAM
--
Kevin A. McGrail
KMcGrail@Apache.org
Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171
Re: New Release Candidate: 3.4.3-rc6 Testers Needed
Posted by Henrik K <he...@hege.li>.
Fyi the main problem is old DNS answers getting around there SA already
finished. Fixed this in trunk a while ago along with some other cleanups.
I don't see it necessary for 3.4.3, been too many delays already, it's
mainly cosmetic.
https://svn.apache.org/viewvc?view=revision&revision=1866126
On Wed, Nov 20, 2019 at 01:45:01PM -0500, Bill Cole wrote:
> +1 for this. Noting the problem at 'info' is good.
>
>
> On 20 Nov 2019, at 13:41, Henrik K wrote:
>
> >On Wed, Nov 20, 2019 at 07:29:10PM +0100, Giovanni Bechis wrote:
> >>anybody against this diff ?
> >>
> >> Giovanni
> >>
> >>Index: lib/Mail/SpamAssassin/DnsResolver.pm
> >>===================================================================
> >>--- lib/Mail/SpamAssassin/DnsResolver.pm (revision 1870052)
> >>+++ lib/Mail/SpamAssassin/DnsResolver.pm (working copy)
> >>@@ -858,7 +858,7 @@
> >> if ($rcode eq 'REFUSED' || $id =~
> >>m{^\d+/NO_QUESTION_IN_PACKET\z}) {
> >> # the failure was already reported above
> >> } else {
> >>- info("dns: no callback for id %s, ignored; packet: %s",
> >>+ dbg("dns: no callback for id %s, ignored; packet: %s",
> >> $id, $packet ? $packet->string : "undef" );
> >> }
> >> # report a likely matching query for diagnostic purposes
> >
> >If you would check trunk it's already there. Please use the same code for
> >uniformity.
> >
> > info("dns: no callback for id $id, ignored, packet on next
> >debug line");
> > # prevent filling normal logs with huge packet dumps
> > dbg("dns: %s", $packet ? $packet->string : "undef");
>
>
> --
> Bill Cole
> bill@scconsult.com or billcole@apache.org
> (AKA @grumpybozo and many *@billmail.scconsult.com addresses)
> Not Currently Available For Hire
Re: New Release Candidate: 3.4.3-rc6 Testers Needed
Posted by Bill Cole <sa...@billmail.scconsult.com>.
+1 for this. Noting the problem at 'info' is good.
On 20 Nov 2019, at 13:41, Henrik K wrote:
> On Wed, Nov 20, 2019 at 07:29:10PM +0100, Giovanni Bechis wrote:
>> anybody against this diff ?
>>
>> Giovanni
>>
>> Index: lib/Mail/SpamAssassin/DnsResolver.pm
>> ===================================================================
>> --- lib/Mail/SpamAssassin/DnsResolver.pm (revision 1870052)
>> +++ lib/Mail/SpamAssassin/DnsResolver.pm (working copy)
>> @@ -858,7 +858,7 @@
>> if ($rcode eq 'REFUSED' || $id =~
>> m{^\d+/NO_QUESTION_IN_PACKET\z}) {
>> # the failure was already reported above
>> } else {
>> - info("dns: no callback for id %s, ignored; packet: %s",
>> + dbg("dns: no callback for id %s, ignored; packet: %s",
>> $id, $packet ? $packet->string : "undef" );
>> }
>> # report a likely matching query for diagnostic purposes
>
> If you would check trunk it's already there. Please use the same code
> for
> uniformity.
>
> info("dns: no callback for id $id, ignored, packet on next
> debug line");
> # prevent filling normal logs with huge packet dumps
> dbg("dns: %s", $packet ? $packet->string : "undef");
--
Bill Cole
bill@scconsult.com or billcole@apache.org
(AKA @grumpybozo and many *@billmail.scconsult.com addresses)
Not Currently Available For Hire
Re: New Release Candidate: 3.4.3-rc6 Testers Needed
Posted by Henrik K <he...@hege.li>.
On Wed, Nov 20, 2019 at 07:29:10PM +0100, Giovanni Bechis wrote:
> anybody against this diff ?
>
> Giovanni
>
> Index: lib/Mail/SpamAssassin/DnsResolver.pm
> ===================================================================
> --- lib/Mail/SpamAssassin/DnsResolver.pm (revision 1870052)
> +++ lib/Mail/SpamAssassin/DnsResolver.pm (working copy)
> @@ -858,7 +858,7 @@
> if ($rcode eq 'REFUSED' || $id =~ m{^\d+/NO_QUESTION_IN_PACKET\z}) {
> # the failure was already reported above
> } else {
> - info("dns: no callback for id %s, ignored; packet: %s",
> + dbg("dns: no callback for id %s, ignored; packet: %s",
> $id, $packet ? $packet->string : "undef" );
> }
> # report a likely matching query for diagnostic purposes
If you would check trunk it's already there. Please use the same code for
uniformity.
info("dns: no callback for id $id, ignored, packet on next debug line");
# prevent filling normal logs with huge packet dumps
dbg("dns: %s", $packet ? $packet->string : "undef");
Re: New Release Candidate: 3.4.3-rc6 Testers Needed
Posted by John Hardin <jh...@impsec.org>.
On Wed, 20 Nov 2019, Kevin A. McGrail wrote:
> +1 to the one line change from info to dbg
Me too.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhardin@impsec.org FALaholic #11174 pgpk -a jhardin@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
The job of QA is to try their hardest to
embarrass the developers privately, because users
will be doing their damnedest to do so publicly.
-----------------------------------------------------------------------
965 days since the first commercial re-flight of an orbital booster (SpaceX)
Re: New Release Candidate: 3.4.3-rc6 Testers Needed
Posted by "Kevin A. McGrail" <km...@apache.org>.
+1 to the one line change from info to dbg
On 11/20/2019 1:29 PM, Giovanni Bechis wrote:
> On Wed, Nov 20, 2019 at 12:14:18PM -0500, Noah Meyerhans wrote:
>> On Sat, Nov 09, 2019 at 02:20:15AM -0500, Kevin A. McGrail wrote:
>>> 3.4.3 release candidate 6 is now available at http://talon2.pccc.com/~kmcgrail/devel/ or http://people.apache.org/~kmcgrail/devel/
>>>
>>> PLEASE NOTE: One of the hold-ups for releasing 3.4.3 has been finding
>>> little bugs while testing new features. As such, we could really use
>>> some people testing the release candidates. I am running these release
>>> candidates in production and have no reservations recommending the same.
>> I uploaded 3.4.3-rc6 to Debian testing and unstable. Hopefully this
>> gets a little more test exposure, though I don't know that there are
>> many people using these distro branches as part of their mail
>> infrastructure. I'll pass along anything I do hear, though.
>>
>> I'm also running rc6 on my mail gateway.
>>
>> The only thing I've noticed so far is the appearance of logs such as the
>> one below. This was discussed briefly in
>> https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7033, in the context
>> of 3.4.0, but was not seen as an issue. However, something has
>> definitely changed with 3.4.3(-rc6). I never saw these messages on my
>> mail host with previous versions of spamassassin (literally zero
>> occurrences in years), but I see dozens of them daily with 3.4.3. I
>> have not changed any other dependencies on this host.
>>
>> Nov 20 09:54:53 amarth spamd[3976]: dns: no callback for id 55444/IN/A/99.29.145.198.dnsbl.sorbs.net, ignored; packet: ;; Response received from 127.0.0.1 (58 octets)
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; HEADER SECTION
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; id = 55444
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; qr = 1 aa = 0 tc = 0 rd = 1 opcode = QUERY
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ra = 1 z = 0 ad = 0 cd = 0 rcode = SERVFAIL
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; qdcount = 1 ancount = 0 nscount = 0 arcount = 1
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; do = 0
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; EDNS version 0
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; flags: 0000
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; rcode: NOERROR
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; size: 4096
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; option:
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; QUESTION SECTION (1 record)
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; 99.29.145.198.dnsbl.sorbs.net. IN A
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ANSWER SECTION (0 records)
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; AUTHORITY SECTION (0 records)
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ADDITIONAL SECTION (1 record)
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; EDNS version 0
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; flags: 0000
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; rcode: NOERROR
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; size: 4096
>> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; option:
>> Nov 20 09:54:53 amarth spamd[3976]: dns: no likely matching queries for id 55444
>>
>> I haven't looked deeply into what has changed. IMO logging something
>> when DNS returns a SERVFAIL makes sense, but this level of detail should
>> probably be reserved for debug severity.
>>
> anybody against this diff ?
>
> Giovanni
>
> Index: lib/Mail/SpamAssassin/DnsResolver.pm
> ===================================================================
> --- lib/Mail/SpamAssassin/DnsResolver.pm (revision 1870052)
> +++ lib/Mail/SpamAssassin/DnsResolver.pm (working copy)
> @@ -858,7 +858,7 @@
> if ($rcode eq 'REFUSED' || $id =~ m{^\d+/NO_QUESTION_IN_PACKET\z}) {
> # the failure was already reported above
> } else {
> - info("dns: no callback for id %s, ignored; packet: %s",
> + dbg("dns: no callback for id %s, ignored; packet: %s",
> $id, $packet ? $packet->string : "undef" );
> }
> # report a likely matching query for diagnostic purposes
--
Kevin A. McGrail
KMcGrail@Apache.org
Member, Apache Software Foundation
Chair Emeritus Apache SpamAssassin Project
https://www.linkedin.com/in/kmcgrail - 703.798.0171
Re: New Release Candidate: 3.4.3-rc6 Testers Needed
Posted by Giovanni Bechis <gi...@paclan.it>.
On Wed, Nov 20, 2019 at 12:14:18PM -0500, Noah Meyerhans wrote:
> On Sat, Nov 09, 2019 at 02:20:15AM -0500, Kevin A. McGrail wrote:
> >
> > 3.4.3 release candidate 6 is now available at http://talon2.pccc.com/~kmcgrail/devel/ or http://people.apache.org/~kmcgrail/devel/
> >
> > PLEASE NOTE: One of the hold-ups for releasing 3.4.3 has been finding
> > little bugs while testing new features. As such, we could really use
> > some people testing the release candidates. I am running these release
> > candidates in production and have no reservations recommending the same.
>
> I uploaded 3.4.3-rc6 to Debian testing and unstable. Hopefully this
> gets a little more test exposure, though I don't know that there are
> many people using these distro branches as part of their mail
> infrastructure. I'll pass along anything I do hear, though.
>
> I'm also running rc6 on my mail gateway.
>
> The only thing I've noticed so far is the appearance of logs such as the
> one below. This was discussed briefly in
> https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7033, in the context
> of 3.4.0, but was not seen as an issue. However, something has
> definitely changed with 3.4.3(-rc6). I never saw these messages on my
> mail host with previous versions of spamassassin (literally zero
> occurrences in years), but I see dozens of them daily with 3.4.3. I
> have not changed any other dependencies on this host.
>
> Nov 20 09:54:53 amarth spamd[3976]: dns: no callback for id 55444/IN/A/99.29.145.198.dnsbl.sorbs.net, ignored; packet: ;; Response received from 127.0.0.1 (58 octets)
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; HEADER SECTION
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; id = 55444
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; qr = 1 aa = 0 tc = 0 rd = 1 opcode = QUERY
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ra = 1 z = 0 ad = 0 cd = 0 rcode = SERVFAIL
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; qdcount = 1 ancount = 0 nscount = 0 arcount = 1
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; do = 0
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; EDNS version 0
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; flags: 0000
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; rcode: NOERROR
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; size: 4096
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; option:
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; QUESTION SECTION (1 record)
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; 99.29.145.198.dnsbl.sorbs.net. IN A
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ANSWER SECTION (0 records)
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; AUTHORITY SECTION (0 records)
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ADDITIONAL SECTION (1 record)
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; EDNS version 0
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; flags: 0000
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; rcode: NOERROR
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; size: 4096
> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; option:
> Nov 20 09:54:53 amarth spamd[3976]: dns: no likely matching queries for id 55444
>
> I haven't looked deeply into what has changed. IMO logging something
> when DNS returns a SERVFAIL makes sense, but this level of detail should
> probably be reserved for debug severity.
>
anybody against this diff ?
Giovanni
Index: lib/Mail/SpamAssassin/DnsResolver.pm
===================================================================
--- lib/Mail/SpamAssassin/DnsResolver.pm (revision 1870052)
+++ lib/Mail/SpamAssassin/DnsResolver.pm (working copy)
@@ -858,7 +858,7 @@
if ($rcode eq 'REFUSED' || $id =~ m{^\d+/NO_QUESTION_IN_PACKET\z}) {
# the failure was already reported above
} else {
- info("dns: no callback for id %s, ignored; packet: %s",
+ dbg("dns: no callback for id %s, ignored; packet: %s",
$id, $packet ? $packet->string : "undef" );
}
# report a likely matching query for diagnostic purposes
Re: New Release Candidate: 3.4.3-rc6 Testers Needed
Posted by Noah Meyerhans <fr...@morgul.net>.
On Sat, Nov 09, 2019 at 02:20:15AM -0500, Kevin A. McGrail wrote:
>
> 3.4.3 release candidate 6 is now available at http://talon2.pccc.com/~kmcgrail/devel/ or http://people.apache.org/~kmcgrail/devel/
>
> PLEASE NOTE: One of the hold-ups for releasing 3.4.3 has been finding
> little bugs while testing new features. As such, we could really use
> some people testing the release candidates. I am running these release
> candidates in production and have no reservations recommending the same.
I uploaded 3.4.3-rc6 to Debian testing and unstable. Hopefully this
gets a little more test exposure, though I don't know that there are
many people using these distro branches as part of their mail
infrastructure. I'll pass along anything I do hear, though.
I'm also running rc6 on my mail gateway.
The only thing I've noticed so far is the appearance of logs such as the
one below. This was discussed briefly in
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7033, in the context
of 3.4.0, but was not seen as an issue. However, something has
definitely changed with 3.4.3(-rc6). I never saw these messages on my
mail host with previous versions of spamassassin (literally zero
occurrences in years), but I see dozens of them daily with 3.4.3. I
have not changed any other dependencies on this host.
Nov 20 09:54:53 amarth spamd[3976]: dns: no callback for id 55444/IN/A/99.29.145.198.dnsbl.sorbs.net, ignored; packet: ;; Response received from 127.0.0.1 (58 octets)
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; HEADER SECTION
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; id = 55444
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; qr = 1 aa = 0 tc = 0 rd = 1 opcode = QUERY
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ra = 1 z = 0 ad = 0 cd = 0 rcode = SERVFAIL
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; qdcount = 1 ancount = 0 nscount = 0 arcount = 1
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; do = 0
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; EDNS version 0
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; flags: 0000
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; rcode: NOERROR
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; size: 4096
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; option:
Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; QUESTION SECTION (1 record)
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; 99.29.145.198.dnsbl.sorbs.net. IN A
Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ANSWER SECTION (0 records)
Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; AUTHORITY SECTION (0 records)
Nov 20 09:54:53 amarth spamd[3976]: dns: [...]
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ADDITIONAL SECTION (1 record)
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; EDNS version 0
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; flags: 0000
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; rcode: NOERROR
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; size: 4096
Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; option:
Nov 20 09:54:53 amarth spamd[3976]: dns: no likely matching queries for id 55444
I haven't looked deeply into what has changed. IMO logging something
when DNS returns a SERVFAIL makes sense, but this level of detail should
probably be reserved for debug severity.
Otherwise, so far, so good. Are there any specific features that you
want to get additional testing?
noah