You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2020/09/02 21:51:00 UTC

[jira] [Created] (CALCITE-4220) In SqlToRelConverter, use RelBuilder for creating Aggregate

Julian Hyde created CALCITE-4220:
------------------------------------

             Summary: In SqlToRelConverter, use RelBuilder for creating Aggregate
                 Key: CALCITE-4220
                 URL: https://issues.apache.org/jira/browse/CALCITE-4220
             Project: Calcite
          Issue Type: Bug
            Reporter: Julian Hyde


In {{SqlToRelConverter}} use {{RelBuilder}} for creating {{Aggregate}}. Currently we call LogicalAggregate.create directly, and that misses some optimizations.

Add config option {{RelBuilder.Config.skipAggOnUniqueKey()}} to disable the optimization that we don't create an {{Aggregate}} if the input is already unique on the GROUP BY key. Without it, some tests in {{SqlToRelConverterTest}} become trivial.

Also, that optimization is not valid if there are multiple group sets. (Because we should output multiple rows, and Project only returns one.) So disable it in that case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)