You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2022/04/07 09:52:06 UTC
[GitHub] [qpid-proton] Jmennius opened a new pull request, #363: NO-JIRA: Fix and improve docs regarding libuv usage
Jmennius opened a new pull request, #363:
URL: https://github.com/apache/qpid-proton/pull/363
CMake variable names are case-sensitive and so `-Dproactor` doesn't work, fix that.
Also, rephrase the section a bit and mention packages required for libuv usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] astitcher merged pull request #363: NO-JIRA: Fix and improve docs regarding libuv usage
Posted by GitBox <gi...@apache.org>.
astitcher merged PR #363:
URL: https://github.com/apache/qpid-proton/pull/363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter commented on pull request #363: NO-JIRA: Fix and improve docs regarding libuv usage
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #363:
URL: https://github.com/apache/qpid-proton/pull/363#issuecomment-1091555554
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#363](https://codecov.io/gh/apache/qpid-proton/pull/363?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c100bf3) into [main](https://codecov.io/gh/apache/qpid-proton/commit/a920192ab29e2845134fd340bf230f223f837243?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a920192) will **increase** coverage by `20.11%`.
> The diff coverage is `n/a`.
> :exclamation: Current head c100bf3 differs from pull request most recent head 0b81afb. Consider uploading reports for the commit 0b81afb to get more accurate results
```diff
@@ Coverage Diff @@
## main #363 +/- ##
===========================================
+ Coverage 68.24% 88.36% +20.11%
===========================================
Files 367 47 -320
Lines 73285 2397 -70888
===========================================
- Hits 50011 2118 -47893
+ Misses 23274 279 -22995
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cpp/examples/direct\_recv.cpp](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL2RpcmVjdF9yZWN2LmNwcA==) | | |
| [cpp/src/reconnect\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9yZWNvbm5lY3RfdGVzdC5jcHA=) | | |
| [cpp/src/uuid.cpp](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy91dWlkLmNwcA==) | | |
| [cpp/src/tracker.cpp](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy90cmFja2VyLmNwcA==) | | |
| [cpp/examples/simple\_recv.cpp](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL3NpbXBsZV9yZWN2LmNwcA==) | | |
| [cpp/src/value.cpp](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy92YWx1ZS5jcHA=) | | |
| [cpp/src/connection\_driver\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb25uZWN0aW9uX2RyaXZlcl90ZXN0LmNwcA==) | | |
| [cpp/examples/ssl.cpp](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL3NzbC5jcHA=) | | |
| [python/tests/proton\_tests/handler.py](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy9oYW5kbGVyLnB5) | | |
| [cpp/src/proactor\_container\_impl.cpp](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9wcm9hY3Rvcl9jb250YWluZXJfaW1wbC5jcHA=) | | |
| ... and [310 more](https://codecov.io/gh/apache/qpid-proton/pull/363/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/363?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/363?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a920192...0b81afb](https://codecov.io/gh/apache/qpid-proton/pull/363?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org