You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Igor Galić <i....@brainsware.org> on 2013/04/20 12:48:41 UTC

Re: [1/6] git commit: TS-1820 Unify the use of UNUSED, and eliminate trash


----- Original Message -----
> Updated Branches:
>   refs/heads/master 21515f600 -> c88d6153e
> 
> 
> TS-1820 Unify the use of UNUSED, and eliminate trash
[snip]
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3840df18/lib/ts/ink_assert.cc
> ----------------------------------------------------------------------
> diff --git a/lib/ts/ink_assert.cc b/lib/ts/ink_assert.cc
> index 9ae5be1..c40ea38 100644
> --- a/lib/ts/ink_assert.cc
> +++ b/lib/ts/ink_assert.cc
> @@ -29,7 +29,6 @@ Assertions
>  #include "ink_platform.h"
>  #include "ink_assert.h"
>  #include "ink_error.h"
> -#include "ink_unused.h"
>  #include "ink_string.h"       /* MAGIC_EDITING_TAG */

does that mean we still have a MAGIC_EDITING_TAG in ink_string.h left, or this comment bogus?

[snip]

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE

Re: [1/6] git commit: TS-1820 Unify the use of UNUSED, and eliminate trash

Posted by Leif Hedstrom <zw...@apache.org>.
On 4/20/13 4:48 AM, Igor Galić wrote:
>
> ----- Original Message -----
>> Updated Branches:
>>    refs/heads/master 21515f600 -> c88d6153e
>>
>>
>> TS-1820 Unify the use of UNUSED, and eliminate trash
> [snip]
>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3840df18/lib/ts/ink_assert.cc
>> ----------------------------------------------------------------------
>> diff --git a/lib/ts/ink_assert.cc b/lib/ts/ink_assert.cc
>> index 9ae5be1..c40ea38 100644
>> --- a/lib/ts/ink_assert.cc
>> +++ b/lib/ts/ink_assert.cc
>> @@ -29,7 +29,6 @@ Assertions
>>   #include "ink_platform.h"
>>   #include "ink_assert.h"
>>   #include "ink_error.h"
>> -#include "ink_unused.h"
>>   #include "ink_string.h"       /* MAGIC_EDITING_TAG */
> does that mean we still have a MAGIC_EDITING_TAG in ink_string.h left, or this comment bogus?

Probably bogus. Fix it Felix :).

-- Leif

>
> [snip]
>