[jira] [Commented] (GEODE-3591) ClientInterestMessageImpl constructor should not call CacheFactory.getAnyInstance

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242866#comment-16242866 ] 

ASF GitHub Bot commented on GEODE-3591:
---------------------------------------

dschneider-pivotal opened a new pull request #1027: GEODE-3591: remove getAnyInstance call
URL: https://github.com/apache/geode/pull/1027
 
 
   Now the DistributedSystem is passed in to the constructor.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ClientInterestMessageImpl constructor should not call CacheFactory.getAnyInstance
> ---------------------------------------------------------------------------------
>
>                 Key: GEODE-3591
>                 URL: https://issues.apache.org/jira/browse/GEODE-3591
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client queues
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>
> The constructor is calling it to get the distributed system.
> The only caller of this constructor is: org.apache.geode.internal.cache.tier.sockets.CacheClientProxy.enqueueInterestRegistrationMessage(ClientInterestMessageImpl)
> and it could instead just pass the distributed system in by passing "this._cache.getDistributedSystem()".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)