[GitHub] [phoenix] dbwong commented on a change in pull request #847: PHOENIX-6022 RVC Offset does not handle trailing nulls properly

[GitBox <gi...@apache.org>]

dbwong commented on a change in pull request #847:
URL: https://github.com/apache/phoenix/pull/847#discussion_r462540663



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/RVCOffsetCompiler.java
##########
@@ -240,34 +246,41 @@ public CompiledOffset getRVCOffset(StatementContext context, FilterableStatement
             }
         }
 
+        byte[] key;
+
         // check to see if this was a single key expression
         ScanRanges scanRanges = context.getScanRanges();
 
+        //We do not generate a point lookup today in phoenix if the rowkey has a trailing null, we generate a range scan.
         if (!scanRanges.isPointLookup()) {
-            throw new RowValueConstructorOffsetNotCoercibleException(
-                    "RVC Offset must be a point lookup.");
-        }
-
-
-        RowKeySchema.RowKeySchemaBuilder builder = new RowKeySchema.RowKeySchemaBuilder(columns.size());
+            //Since we use a range scan to garuntee we get only the null value and the upper bound is unset this suffices

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org