You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dineshkumar Yadav <di...@outlook.com> on 2020/11/05 14:27:05 UTC
Re: Review Request 73003: RANGER-3071 : Supporting character set
which is not included in latin1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73003/
-----------------------------------------------------------
(Updated Nov. 5, 2020, 2:27 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
Bugs: RANGER-3071
https://issues.apache.org/jira/browse/RANGER-3071
Repository: ranger
Description
-------
Currently we are supporting only character set included in latin1. Though most of the character supported by Latin1 but not all character used in different languages.
This need to be fixed for all the DB supported by Ranger.
MS SQL server is not able to handle such character. Other DB flavors are handling it currently
Solution:
changing varchar datatypes to Nvarchar for UserName, GroupName and RoleName only.
Diffs
-----
security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql addb56677
security-admin/db/sqlserver/patches/050-update-datatype-to-nvarchar.sql PRE-CREATION
Diff: https://reviews.apache.org/r/73003/diff/1/
Testing
-------
After Patch non-latin charactres are also allows in UserName, GroupName and RoleName
Thanks,
Dineshkumar Yadav
Re: Review Request 73003: RANGER-3071 : Supporting character set
which is not included in latin1
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73003/#review222188
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Nov. 10, 2020, 10:41 a.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73003/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2020, 10:41 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3071
> https://issues.apache.org/jira/browse/RANGER-3071
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently we are supporting only character set included in latin1. Though most of the character supported by Latin1 but not all character used in different languages.
>
>
> This need to be fixed for all the DB supported by Ranger.
> MS SQL server is not able to handle such character. Other DB flavors are handling it currently
>
> Solution:
> changing varchar datatypes to Nvarchar for UserName, GroupName and RoleName only.
>
>
> Diffs
> -----
>
> security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 7afabba6a
> security-admin/db/sqlserver/patches/051-update-datatype-to-nvarchar.sql PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/73003/diff/2/
>
>
> Testing
> -------
>
> After Patch non-latin charactres are also allows in UserName, GroupName and RoleName
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>
Re: Review Request 73003: RANGER-3071 : Supporting character set
which is not included in latin1
Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73003/
-----------------------------------------------------------
(Updated Nov. 10, 2020, 10:41 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
Changes
-------
updated patch number
Bugs: RANGER-3071
https://issues.apache.org/jira/browse/RANGER-3071
Repository: ranger
Description
-------
Currently we are supporting only character set included in latin1. Though most of the character supported by Latin1 but not all character used in different languages.
This need to be fixed for all the DB supported by Ranger.
MS SQL server is not able to handle such character. Other DB flavors are handling it currently
Solution:
changing varchar datatypes to Nvarchar for UserName, GroupName and RoleName only.
Diffs (updated)
-----
security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 7afabba6a
security-admin/db/sqlserver/patches/051-update-datatype-to-nvarchar.sql PRE-CREATION
Diff: https://reviews.apache.org/r/73003/diff/2/
Changes: https://reviews.apache.org/r/73003/diff/1-2/
Testing
-------
After Patch non-latin charactres are also allows in UserName, GroupName and RoleName
Thanks,
Dineshkumar Yadav
Re: Review Request 73003: RANGER-3071 : Supporting character set
which is not included in latin1
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73003/#review222171
-----------------------------------------------------------
security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql
Lines 4099 (patched)
<https://reviews.apache.org/r/73003/#comment311236>
Please check if this java patch number is already being used for any pending Apache JIRA (Please check RANGER-3067)
- Abhay Kulkarni
On Nov. 5, 2020, 2:27 p.m., Dineshkumar Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73003/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2020, 2:27 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3071
> https://issues.apache.org/jira/browse/RANGER-3071
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently we are supporting only character set included in latin1. Though most of the character supported by Latin1 but not all character used in different languages.
>
>
> This need to be fixed for all the DB supported by Ranger.
> MS SQL server is not able to handle such character. Other DB flavors are handling it currently
>
> Solution:
> changing varchar datatypes to Nvarchar for UserName, GroupName and RoleName only.
>
>
> Diffs
> -----
>
> security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql addb56677
> security-admin/db/sqlserver/patches/050-update-datatype-to-nvarchar.sql PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/73003/diff/1/
>
>
> Testing
> -------
>
> After Patch non-latin charactres are also allows in UserName, GroupName and RoleName
>
>
> Thanks,
>
> Dineshkumar Yadav
>
>