[jira] [Commented] (EMPIREDB-196) Implement limitRows and skipRows for H2 database

["Rainer Döbele (JIRA)" <em...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/EMPIREDB-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796883#comment-13796883 ] 

Rainer Döbele commented on EMPIREDB-196:
----------------------------------------

Hello Bimal,

thanks a lot for your contribution.
I have applied your patch and checked it in.
It is now availabe from our svn.

Regards
Rainer

> Implement limitRows and skipRows for H2 database 
> -------------------------------------------------
>
>                 Key: EMPIREDB-196
>                 URL: https://issues.apache.org/jira/browse/EMPIREDB-196
>             Project: Empire-DB
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: empire-db-2.4.2
>            Reporter: Bimal Manukonda
>         Attachments: DBDatabaseDriverH2.java
>
>
> Currently, limitRows and skipRows is not implemented for H2 database.
> This would be needed if we were to have paginated data source in applications.
>            @Override
>             public void getSelect(StringBuilder buf)
>             {   // Prepares statement
>             	super.getSelect(buf);
>                 // add limit and offset
>                 if (limit>=0)
>                 {   buf.append("\r\nLIMIT ");
>                     buf.append(String.valueOf(limit));
>                     // Offset
>                     if (skip>=0) 
>                     {   buf.append(" OFFSET ");
>                         buf.append(String.valueOf(skip));
>                     }    
>                 }
>             }



--
This message was sent by Atlassian JIRA
(v6.1#6144)