You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by hanm <gi...@git.apache.org> on 2017/04/04 23:44:56 UTC
[GitHub] zookeeper pull request #213: ZOOKEEPER-2746: remove the check on the new lea...
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/213
ZOOKEEPER-2746: remove the check on the new leader after a dynamic re\u2026
\u2026config operation.
This check might not always hold because the nominated leader could fail to lead the quorum during sync phase - for example if sync time out [when waiting for quorum ack](https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L1232). I am thinking we should just remove this instead of fixing it because the nominated leader is not an interface level contract / guarantee but a best effort / implementation level details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2746
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #213
----
commit 9e367d6f46811233b4bac169f5abb58ff1777273
Author: Michael Han <ha...@apache.org>
Date: 2017-04-04T23:41:09Z
ZOOKEEPER-2746: remove the check on the new leader after a dynamic reconfig operation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #213: ZOOKEEPER-2746: remove the check on the new lea...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #213: ZOOKEEPER-2746: remove the check on the new leader aft...
Posted by shralex <gi...@git.apache.org>.
Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/213
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #213: ZOOKEEPER-2746: remove the check on the new leader aft...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/213
@shralex one code review for you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---