You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Michael Jakl (JIRA)" <ji...@apache.org> on 2009/06/22 22:53:07 UTC
[jira] Created: (VYSPER-79) Extract smaller methods for better
annotations and improved structure/readability.
Extract smaller methods for better annotations and improved structure/readability.
----------------------------------------------------------------------------------
Key: VYSPER-79
URL: https://issues.apache.org/jira/browse/VYSPER-79
Project: VYSPER
Issue Type: Sub-task
Components: XEP0060 PubSub
Reporter: Michael Jakl
Assignee: Michael Jakl
Some methods touch on more than one sub-section of the XEP. Maybe it's best to decompose these parts into their own methods, which could be annotated with their respective sections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Adding more than one @SpecCompliant [WAS: Re: [jira] Resolved: (VYSPER-79)
Extract smaller methods for better annotations and improved structure/readability.]
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Michael Jakl (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/VYSPER-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Michael Jakl resolved VYSPER-79.
> --------------------------------
>
> Resolution: Fixed
>
> Added SpecCompliant annotation to handleSet methods (although, only it's only possible to add one per method).
Using @SpecCompliance, you can add an arbitrary number of @SpecCompliant
annotations. See for example RosterIQHandler:
@SpecCompliance( compliant = {
@SpecCompliant(spec="rfc3921bis-08", section = "2.1.2", status =
FINISHED, coverage = COMPLETE),
@SpecCompliant(spec="rfc3921bis-08", section = "2.1.5", status =
FINISHED, coverage = PARTIAL),
@SpecCompliant(spec="rfc3921bis-08", section = "2.2", status =
FINISHED, coverage = COMPLETE)
})
@Override
protected Stanza handleGet(IQStanza stanza, ServerRuntimeContext
serverRuntimeContext, SessionContext sessionContext) {
Bernd
>
>> Extract smaller methods for better annotations and improved structure/readability.
>> ----------------------------------------------------------------------------------
>>
>> Key: VYSPER-79
>> URL: https://issues.apache.org/jira/browse/VYSPER-79
>> Project: VYSPER
>> Issue Type: Sub-task
>> Components: XEP0060 PubSub
>> Reporter: Michael Jakl
>> Assignee: Michael Jakl
>>
>> Some methods touch on more than one sub-section of the XEP. Maybe it's best to decompose these parts into their own methods, which could be annotated with their respective sections.
>
[jira] Resolved: (VYSPER-79) Extract smaller methods for better
annotations and improved structure/readability.
Posted by "Michael Jakl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Jakl resolved VYSPER-79.
--------------------------------
Resolution: Fixed
Added SpecCompliant annotation to handleSet methods (although, only it's only possible to add one per method).
> Extract smaller methods for better annotations and improved structure/readability.
> ----------------------------------------------------------------------------------
>
> Key: VYSPER-79
> URL: https://issues.apache.org/jira/browse/VYSPER-79
> Project: VYSPER
> Issue Type: Sub-task
> Components: XEP0060 PubSub
> Reporter: Michael Jakl
> Assignee: Michael Jakl
>
> Some methods touch on more than one sub-section of the XEP. Maybe it's best to decompose these parts into their own methods, which could be annotated with their respective sections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (VYSPER-79) Extract smaller methods for better
annotations and improved structure/readability.
Posted by "Michael Jakl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Jakl closed VYSPER-79.
------------------------------
> Extract smaller methods for better annotations and improved structure/readability.
> ----------------------------------------------------------------------------------
>
> Key: VYSPER-79
> URL: https://issues.apache.org/jira/browse/VYSPER-79
> Project: VYSPER
> Issue Type: Sub-task
> Components: XEP0060 PubSub
> Reporter: Michael Jakl
> Assignee: Michael Jakl
>
> Some methods touch on more than one sub-section of the XEP. Maybe it's best to decompose these parts into their own methods, which could be annotated with their respective sections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VYSPER-79) Extract smaller methods for better
annotations and improved structure/readability.
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722823#action_12722823 ]
Bernd Fondermann commented on VYSPER-79:
----------------------------------------
If it fits for both (annotations and code structuring), fine.
IMHO, annotations should not primarily drive the granularity of methods.
Another solution is to add more than one SpecCompliant annotation for the same method.
> Extract smaller methods for better annotations and improved structure/readability.
> ----------------------------------------------------------------------------------
>
> Key: VYSPER-79
> URL: https://issues.apache.org/jira/browse/VYSPER-79
> Project: VYSPER
> Issue Type: Sub-task
> Components: XEP0060 PubSub
> Reporter: Michael Jakl
> Assignee: Michael Jakl
>
> Some methods touch on more than one sub-section of the XEP. Maybe it's best to decompose these parts into their own methods, which could be annotated with their respective sections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.