You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/03 17:58:36 UTC

[GitHub] [geode] davebarnes97 commented on a change in pull request #5207: GEODE-8218: Update docs to reflect changes to default redis-bind-adress behavior

davebarnes97 commented on a change in pull request #5207:
URL: https://github.com/apache/geode/pull/5207#discussion_r434752759



##########
File path: geode-docs/reference/topics/gemfire_properties.html.md.erb
##########
@@ -489,7 +489,7 @@ off-heap-memory-size=120g</code></pre></td>
 <tr>
 <td>redis-bind-address</td>
 <td>Specifies the address on which the Redis API for <%=vars.product_name%> is listening. If set to the empty string or this property is not
-specified, localhost is requested from the operating system.</td>
+specified, the server will listen on all local addresses.

Review comment:
       For consistency and ease of understanding, I recommend present tense:
   
   ...the server listens on all local addresses.
   
   I'd like to see this change adopted for the doc (.erb) file, at least. I recommend it for the .java files, as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org