You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/12/12 16:49:59 UTC

[GitHub] [ignite] x-kreator commented on a change in pull request #6886: IGNITE-12200 More informative assertion message at constructor of Cac…

x-kreator commented on a change in pull request #6886: IGNITE-12200 More informative assertion message at constructor of Cac…
URL: https://github.com/apache/ignite/pull/6886#discussion_r357255161
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheDeploymentManager.java
 ##########
 @@ -921,7 +921,8 @@ private boolean isLocallyExcluded(String name) {
          */
         private CachedDeploymentInfo(UUID sndId, IgniteUuid ldrId, String userVer, DeploymentMode depMode,
             Map<UUID, IgniteUuid> participants) {
-            assert sndId.equals(ldrId.globalId()) || participants != null;
+            assert sndId.equals(ldrId.globalId()) || participants != null
 
 Review comment:
   Assertion error can be fired only if participants=null, I met the IDE warning about that when wrote that message construction expression earlier. But if you strongly recommend to do that, I'll do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services