You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2020/01/03 11:24:12 UTC
svn commit: r1872283 -
/poi/trunk/src/ooxml/java/org/apache/poi/ooxml/POIXMLDocumentPart.java
Author: fanningpj
Date: Fri Jan 3 11:24:12 2020
New Revision: 1872283
URL: http://svn.apache.org/viewvc?rev=1872283&view=rev
Log:
remove unnecessary close
Modified:
poi/trunk/src/ooxml/java/org/apache/poi/ooxml/POIXMLDocumentPart.java
Modified: poi/trunk/src/ooxml/java/org/apache/poi/ooxml/POIXMLDocumentPart.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/ooxml/POIXMLDocumentPart.java?rev=1872283&r1=1872282&r2=1872283&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/ooxml/POIXMLDocumentPart.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/ooxml/POIXMLDocumentPart.java Fri Jan 3 11:24:12 2020
@@ -767,7 +767,6 @@ public class POIXMLDocumentPart {
if (coreRel != null) {
PackagePart pp = pkg.getPart(coreRel);
if (pp == null) {
- closeQuietly(pp);
throw new POIXMLException("OOXML file structure broken/invalid - core document '" + coreRel.getTargetURI() + "' not found.");
}
return pp;
@@ -781,19 +780,4 @@ public class POIXMLDocumentPart {
throw new POIXMLException("OOXML file structure broken/invalid - no core document found!");
}
-
- private static void closeQuietly(final PackagePart closeable) {
- // no need to log a NullPointerException here
- if(closeable == null) {
- return;
- }
-
- try {
- closeable.close();
- } catch ( Exception exc ) {
- logger.log( POILogger.ERROR, "Unable to close resource: " + exc,
- exc );
- }
- }
-
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org