You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by "Shanedell (via GitHub)" <gi...@apache.org> on 2023/05/04 01:22:07 UTC

[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #620: Launch wizard updates and rename data editor vars

Shanedell commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1184450086


##########
package.json:
##########
@@ -627,17 +618,17 @@
             },
             "default": {}
           },
-          "dataEditor.omegaEditPort": {
+          "dataEditorOmegaEditPort": {

Review Comment:
   I believe they should all keep `dataEditor` so we are aware of what they are for. These ones are used for getting default values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org