[GitHub] [incubator-nuttx] Gary-Hobson commented on a diff in pull request #7688: include: unified stream read and write interface

[GitBox <gi...@apache.org>]

Gary-Hobson commented on code in PR #7688:
URL: https://github.com/apache/incubator-nuttx/pull/7688#discussion_r1031721935


##########
include/nuttx/streams.h:
##########
@@ -40,6 +40,16 @@
  * Pre-processor Definitions
  ****************************************************************************/
 
+#define stream_write(stream, buf, len) \
+        (( FAR struct lib_outstream_s *)stream)->puts \
+        (( FAR struct lib_outstream_s *)stream, buf, len)
+#define stream_putc(stream, buf, len) \
+        (( FAR struct lib_outstream_s *)stream)->putc \
+        (( FAR struct lib_outstream_s *)stream, ch)
+#define stream_getc(stream) \

Review Comment:
   What are the functions of nput and nget?
   
   In all the code, I only see the value of modifying it, but no one has ever used it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org