You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@apache.org> on 2020/09/16 19:06:24 UTC
Review Request 72875: Consolidated protobuf construction by the JNI
scheduler driver.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72875/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10189
https://issues.apache.org/jira/browse/MESOS-10189
Repository: mesos
Description
-------
This patch converts the copy-pasted internals of numerous
`construct<>()` specializations for protobufs into a single
template.
Diffs
-----
src/java/jni/construct.cpp 8d8f76e4602e506faa635970f096d344a9ad8562
Diff: https://reviews.apache.org/r/72875/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72875: Consolidated protobuf construction by the
JNI scheduler driver.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72875/#review221897
-----------------------------------------------------------
Ship it!
Nice, thanks!
- Benjamin Mahler
On Sept. 16, 2020, 7:06 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72875/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2020, 7:06 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10189
> https://issues.apache.org/jira/browse/MESOS-10189
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch converts the copy-pasted internals of numerous
> `construct<>()` specializations for protobufs into a single
> template.
>
>
> Diffs
> -----
>
> src/java/jni/construct.cpp 8d8f76e4602e506faa635970f096d344a9ad8562
>
>
> Diff: https://reviews.apache.org/r/72875/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>