You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/02 18:37:31 UTC
[GitHub] [airflow] mariotaddeucci opened a new pull request, #24804: Add note about how dag policy works with default_args parameter.
mariotaddeucci opened a new pull request, #24804:
URL: https://github.com/apache/airflow/pull/24804
Add note to cluster policies docs alerting that DAG Policy will note override the parameter `default_args` considering the explanation on #24562
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #24804: Note how DAG policy works with default_args
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #24804:
URL: https://github.com/apache/airflow/pull/24804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #24804: Add note about how dag policy works with default_args parameter.
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #24804:
URL: https://github.com/apache/airflow/pull/24804#discussion_r912636047
##########
docs/apache-airflow/concepts/cluster-policies.rst:
##########
@@ -54,6 +54,8 @@ This policy checks if each DAG has at least one tag defined:
To avoid import cycles, if you use ``DAG`` in type annotations in your cluster policy, be sure to import from ``airflow.models`` and not from ``airflow``.
+ DAG policies are applied after the DAG has been completely loaded, so overriding the ``default_args`` parameter will have no effect. If you want to override the default operator settings, consider to use task policies.
Review Comment:
We should do this in a [callout block](https://docutils.sourceforge.io/docs/ref/rst/directives.html#warning).
LGTM otherwise. Thanks a ton!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org