[GitHub] [ignite] ptupitsyn commented on a change in pull request #8726: IGNITE-13763: Add connection limit for C++ thin client

[GitBox <gi...@apache.org>]

ptupitsyn commented on a change in pull request #8726:
URL: https://github.com/apache/ignite/pull/8726#discussion_r566752478



##########
File path: modules/platforms/cpp/thin-client/include/ignite/thin/ignite_client_configuration.h
##########
@@ -230,6 +231,29 @@ namespace ignite
                 return partitionAwareness;
             }
 
+            /**
+             * Get connection limit.
+             * Zero means that number of active connections is not limited.

Review comment:
       What if I set `-1`?

##########
File path: modules/platforms/cpp/thin-client/include/ignite/thin/ignite_client_configuration.h
##########
@@ -230,6 +231,29 @@ namespace ignite
                 return partitionAwareness;
             }
 
+            /**
+             * Get connection limit.

Review comment:
       Let's explain in more detail, something like `with Partition Awareness enabled, thin client establishes a connection to every server node in the cluster. Use this setting to limit the number of active connections. This reduces the resource usage, but can have a negative effect on cache operation performance`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org