You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/22 01:38:48 UTC

[GitHub] [beam] lostluck commented on a change in pull request #11489: [BEAM-9577] Ensure required directories exist when staging.

lostluck commented on a change in pull request #11489:
URL: https://github.com/apache/beam/pull/11489#discussion_r412605572



##########
File path: sdks/go/pkg/beam/artifact/materialize.go
##########
@@ -128,6 +128,11 @@ func (a artifact) retrieve(ctx context.Context, dest string) error {
 		return errors.Wrapf(err, "failed to stat %v", filename)
 	}
 
+	err = os.MkdirAll(filepath.Dir(filename), os.ModePerm)
+	if err != nil {

Review comment:
       Nit: could be inlined into the if (and change the = to := ) but it's not worth blocking for.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org