[jira] Issue Comment Edited: (PIG-243) Make pig work on Windows

["Daniel Dai (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600384#action_12600384 ] 

daijy edited comment on PIG-243 at 6/24/08 9:56 AM:
---------------------------------------------------------

Attached patch fix -most- all problems under cygwin. -4 errors remaining in TestStreaming for map-reduce testing under cygwin need further work.- Patch is tested in both Linux and Cygwin. Here is a list of detected problem and solution:
||Problem||Affected Testcase||Solution||
|Windows path delimit "\" interpreted as escape in java|TestMapReduceResultRecycling, TestMapReduce, TestOrderBy, TestBuiltin, TestFilterOpNumeric, TestBinaryStorage, TestFilterOpString, TestEvalPipeline, TestPigFile, TestReversibleLoadStore, TestAlgebraicEval, TestLargeFile, TestCombiner, TestPi |replace "\" with "\ \", see [http://issues.apache.org/jira/browse/PIG-152]|
| Runtime.exec(String[]) fail for perl -e if perl statement include quote character for unknown reason |TestParamSubPreproc, TestStreaming|append a escape character \ to quote character " under Windows|
| There is a tailing '\r' (0x0d) character for line read from text file under cygwin|TestBuiltin, TestEvalPipeline, TestPigSplit, TestStreaming|remove tailing '\r' |
| Bug: forget to close output stream, following deletion operation fail|TestBinaryStorage|Fix bug |
| Pig streaming put the current directory into PATH. Current directory is obtained using "System.getProperty("user.dir")", it is a Windows style path under cygwin. However, Cygwin only accept Unix style path in PATH environment variable. So put the Windows path obtained from "System.getProperty" directly into PATH will not work | TestStreaming | Change Windows path to Unix path under Cygwin. Using Cygwin utility "cygpath"|
Only two change are in core code. One is PigStorage.java (to fix tailing '\r'). The other is ExecutableManager (Add cygpath). All other changes are in testcase. 

      was (Author: daijy):
    Attached patch fix most problems under cygwin. 4 errors remaining in TestStreaming for map-reduce testing under cygwin need further work. Patch is tested in both Linux and Cygwin. Here is a list of detected problem and solution:
||Problem||Affected Testcase||Solution||
|Windows path delimit "\" interpreted as escape in java|TestMapReduceResultRecycling, TestMapReduce, TestOrderBy, TestBuiltin, TestFilterOpNumeric, TestBinaryStorage, TestFilterOpString, TestEvalPipeline, TestPigFile, TestReversibleLoadStore, TestAlgebraicEval, TestLargeFile, TestCombiner, TestPi |replace "\" with "\ \", see [http://issues.apache.org/jira/browse/PIG-152]|
| Runtime.exec(String[]) fail for perl -e if perl statement include quote character for unknown reason |TestParamSubPreproc, TestStreaming|append a escape character \ to quote character " under Windows|
| There is a tailing '\r' (0x0d) character for line read from text file under cygwin|TestBuiltin, TestEvalPipeline, TestPigSplit, TestStreaming|remove tailing '\r' |
| Bug: forget to close output stream, following deletion operation fail|TestBinaryStorage|Fix bug |

Only one change to PigStorage.java (to fix tailing '\r') is inside core code. All other changes are in testcase. 
  
> Make pig work on Windows
> ------------------------
>
>                 Key: PIG-243
>                 URL: https://issues.apache.org/jira/browse/PIG-243
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: cygpath.patch, PIG_243.patch
>
>
> Currently a large number of unit tests is failing on Windows. We need to fix that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.