[GitHub] spark pull request #13778: [SPARK-16062][SPARK-15989][SQL] Fix two bugs of P...

[viirya <gi...@git.apache.org>]

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13778#discussion_r69698991
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ---
    @@ -346,14 +346,38 @@ case class LambdaVariable(value: String, isNull: String, dataType: DataType) ext
     object MapObjects {
       private val curId = new java.util.concurrent.atomic.AtomicInteger()
     
    +  /**
    +   * Construct an instance of MapObjects case class.
    +   *
    +   * @param function The function applied on the collection elements.
    +   * @param inputData An expression that when evaluated returns a collection object.
    +   * @param elementType The data type of elements in the collection.
    +   */
       def apply(
           function: Expression => Expression,
           inputData: Expression,
           elementType: DataType): MapObjects = {
    +    apply(function, inputData, elementType, inputData.dataType)
    +  }
    +
    +  /**
    +   * Construct an instance of MapObjects case class.
    +   *
    +   * @param function The function applied on the collection elements.
    +   * @param inputData An expression that when evaluated returns a collection object.
    +   * @param elementType The data type of elements in the collection.
    +   * @param inputDataType The explicitly given data type of inputData to override the
    +   *                      data type inferred from inputData (i.e., inputData.dataType).
    --- End diff --
    
    OK. Added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org