[GitHub] [airflow] potiuk commented on issue #27069: test_heartbeat_failed_fast not failing fast enough.

[GitBox <gi...@apache.org>]

potiuk commented on issue #27069:
URL: https://github.com/apache/airflow/issues/27069#issuecomment-1288240448

   I think better solution would be to make it independent of the time. This is an inherent problem of tests that depend on particular timing that they might and will fail eventually. So better solution would be to fix the tests so that they do not dependen on timing. This can be handled better by introducing events and waiting for those. 
   
   And I encourage you to try to do it :) 
   
   But since this is often difficult to do and might require huge investment, if we can asses that we can safely increase such timers, we can do it to as "good-enough". There is never a "0-1" answer, this is left to the judgment of the person proposing such PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org