You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by "joni-jones (via GitHub)" <gi...@apache.org> on 2023/09/06 17:08:44 UTC
[GitHub] [openwhisk] joni-jones opened a new pull request, #5440: Missed config keys on Scala 2.13.x
joni-jones opened a new pull request, #5440:
URL: https://github.com/apache/openwhisk/pull/5440
## Desscription
The origin of issue is iteration through the config keys [here](https://github.com/apache/openwhisk/blob/master/common/scala/src/main/scala/org/apache/openwhisk/common/Config.scala#L145) and [here](https://github.com/apache/openwhisk/blob/master/common/scala/src/main/scala/org/apache/openwhisk/common/Config.scala#L156) and at the same time properties [change](https://github.com/apache/openwhisk/blob/master/common/scala/src/main/scala/org/apache/openwhisk/common/Config.scala#L150) in the loop which can lead to skipping some keys after `+=`.
- Fixed an issue with missed config keys while iterating through them on Scala 2.13.x
!Note: This issue reproduces only on Scala >= 2.13.x version and probably related to some internal changes in Scala.
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Scheduler
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
- [x] Bug fix (generally a non-breaking change which closes an issue).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Missed config keys on Scala 2.13.x [openwhisk]
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 merged PR #5440:
URL: https://github.com/apache/openwhisk/pull/5440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Missed config keys on Scala 2.13.x [openwhisk]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5440:
URL: https://github.com/apache/openwhisk/pull/5440#issuecomment-1749954846
## [Codecov](https://app.codecov.io/gh/apache/openwhisk/pull/5440?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5440](https://app.codecov.io/gh/apache/openwhisk/pull/5440?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1558e79) into [master](https://app.codecov.io/gh/apache/openwhisk/commit/20f7d98fdfba275bc3e5c88be0b7cdec956df2aa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (20f7d98) will **decrease** coverage by `72.32%`.
> Report is 3 commits behind head on master.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1558e79 differs from pull request most recent head 10c1cae. Consider uploading reports for the commit 10c1cae to get more accurate results
```diff
@@ Coverage Diff @@
## master #5440 +/- ##
==========================================
- Coverage 76.82% 4.51% -72.32%
==========================================
Files 241 241
Lines 14632 14634 +2
Branches 616 627 +11
==========================================
- Hits 11241 660 -10581
- Misses 3391 13974 +10583
```
| [Files](https://app.codecov.io/gh/apache/openwhisk/pull/5440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ain/scala/org/apache/openwhisk/common/Config.scala](https://app.codecov.io/gh/apache/openwhisk/pull/5440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db25maWcuc2NhbGE=) | `2.94% <0.00%> (-81.44%)` | :arrow_down: |
... and [205 files with indirect coverage changes](https://app.codecov.io/gh/apache/openwhisk/pull/5440/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org