You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/05/07 01:15:26 UTC
Review Request 66977: Re-enable epoll support for libevent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66977/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
Bugs: MESOS-8881
https://issues.apache.org/jira/browse/MESOS-8881
Repository: mesos
Description
-------
Epoll support was disabled due to some undocumented "issues". Since
the original author is not responsive and a lot of libevent / SSL
issues have been fixed, we can try re-enabling epoll support.
Should this be an issue, epoll can be disabled once again using the
EVENT_NOEPOLL environment variable.
Diffs
-----
3rdparty/libprocess/src/libevent.cpp eb3998c2043c7c8be2a6ea1458bb3e1824f6df1e
Diff: https://reviews.apache.org/r/66977/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 66977: Re-enable epoll support for libevent.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66977/#review202530
-----------------------------------------------------------
PASS: Mesos patch 66977 was successfully built and tested.
Reviews applied: `['66977']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66977
- Mesos Reviewbot Windows
On May 7, 2018, 1:15 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66977/
> -----------------------------------------------------------
>
> (Updated May 7, 2018, 1:15 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
>
>
> Bugs: MESOS-8881
> https://issues.apache.org/jira/browse/MESOS-8881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Epoll support was disabled due to some undocumented "issues". Since
> the original author is not responsive and a lot of libevent / SSL
> issues have been fixed, we can try re-enabling epoll support.
>
> Should this be an issue, epoll can be disabled once again using the
> EVENT_NOEPOLL environment variable.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/libevent.cpp eb3998c2043c7c8be2a6ea1458bb3e1824f6df1e
>
>
> Diff: https://reviews.apache.org/r/66977/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 66977: Re-enable epoll support for libevent.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66977/#review202572
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On May 7, 2018, 1:15 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66977/
> -----------------------------------------------------------
>
> (Updated May 7, 2018, 1:15 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
>
>
> Bugs: MESOS-8881
> https://issues.apache.org/jira/browse/MESOS-8881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Epoll support was disabled due to some undocumented "issues". Since
> the original author is not responsive and a lot of libevent / SSL
> issues have been fixed, we can try re-enabling epoll support.
>
> Should this be an issue, epoll can be disabled once again using the
> EVENT_NOEPOLL environment variable.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/libevent.cpp eb3998c2043c7c8be2a6ea1458bb3e1824f6df1e
>
>
> Diff: https://reviews.apache.org/r/66977/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>