You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "divijvaidya (via GitHub)" <gi...@apache.org> on 2023/05/03 18:20:36 UTC

[GitHub] [kafka] divijvaidya opened a new pull request, #13670: KAFKA-14962: Trim whitespace from ACL configuration

divijvaidya opened a new pull request, #13670:
URL: https://github.com/apache/kafka/pull/13670

   Kafka's startup can fail (see the exception trace below) if there is a trailing or leading whitespace for a configuration value. This fix makes it more tolerant towards cases where a user might accidentally add a trailing or leading whitespace in ACL configuration.
   
   ```
   ERROR [KafkaServer id=3] Fatal error during KafkaServer startup. Prepare to shutdown (kafka.server.KafkaServer)
   
   java.lang.IllegalArgumentException: For input string: "true "
   
       at scala.collection.StringOps$.toBooleanImpl$extension(StringOps.scala:943)
   
       at kafka.security.authorizer.AclAuthorizer.$anonfun$configure$4(AclAuthorizer.scala:153) 
   ```    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] omkreddy merged pull request #13670: KAFKA-14962: Trim whitespace from ACL configuration

Posted by "omkreddy (via GitHub)" <gi...@apache.org>.
omkreddy merged PR #13670:
URL: https://github.com/apache/kafka/pull/13670


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] divijvaidya commented on pull request #13670: KAFKA-14962: Trim whitespace from ACL configuration

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13670:
URL: https://github.com/apache/kafka/pull/13670#issuecomment-1547776798

   @omkreddy Thank you for your review bandwidth to merge this in 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] divijvaidya commented on pull request #13670: KAFKA-14962: Trim whitespace from ACL configuration

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #13670:
URL: https://github.com/apache/kafka/pull/13670#issuecomment-1536300068

   The failing tests are unrelated:
   ```
   Build / JDK 8 and Scala 2.12 / testElectUncleanLeadersForOnePartition(String).quorum=kraft – kafka.api.PlaintextAdminIntegrationTest
   26s
   Build / JDK 11 and Scala 2.13 / testSingleNodeCluster() – org.apache.kafka.connect.mirror.integration.DedicatedMirrorIntegrationTest
   1m 18s
   Build / JDK 11 and Scala 2.13 / testMultiNodeCluster() – org.apache.kafka.connect.mirror.integration.DedicatedMirrorIntegrationTest
   1m 52s
   Build / JDK 11 and Scala 2.13 / testReplicateSourceDefault() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org