[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #388: [FLINK-29232] File store continuous reading support from_timestamp scan mode

[GitBox <gi...@apache.org>]

SteNicholas commented on code in PR #388:
URL: https://github.com/apache/flink-table-store/pull/388#discussion_r1027005215


##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java:
##########
@@ -130,4 +119,42 @@ public SplitEnumerator<FileStoreSourceSplit, PendingSplitsCheckpoint> restoreEnu
             return new StaticFileStoreSplitEnumerator(context, snapshot, splits);
         }
     }
+
+    private DataFilePlan batchScanSplits(DataTableScan scan) {
+        return scan.plan();
+    }
+
+    private DataFilePlan continuousFirstScanSplits(
+            DataTableScan scan, SnapshotManager snapshotManager) {
+        switch (startupMode) {

Review Comment:
   Is it better to introduce `DataFilePlanBuilder` to create `DataFilePlan` for different startup mode?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org