You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jamesnetherton (via GitHub)" <gi...@apache.org> on 2024/06/11 10:49:05 UTC
[PR] Add elasticsearch-rest-client native support [camel-quarkus]
jamesnetherton opened a new pull request, #6176:
URL: https://github.com/apache/camel-quarkus/pull/6176
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add elasticsearch-rest-client native support [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #6176:
URL: https://github.com/apache/camel-quarkus/pull/6176#issuecomment-2160739708
> Noticed [basic auth](https://camel.apache.org/components/3.22.x/elasticsearch-rest-component.html#_configure_the_component_and_enable_basic_authentication) and [multisearch](https://camel.apache.org/components/3.22.x/elasticsearch-rest-component.html#_multisearch_example) seems uncovered. Not sure it's worth adding native test coverge for this in anoher pr.
That's the `3.22.x` documentation for `elasticsearch-rest`. `elasticsearch-rest-client` is slightly different. There is no `multisearch` option.
All of the routes under test use authentication, so that part is covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add elasticsearch-rest-client native support [camel-quarkus]
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #6176:
URL: https://github.com/apache/camel-quarkus/pull/6176#issuecomment-2160759691
> > Noticed [basic auth](https://camel.apache.org/components/3.22.x/elasticsearch-rest-component.html#_configure_the_component_and_enable_basic_authentication) and [multisearch](https://camel.apache.org/components/3.22.x/elasticsearch-rest-component.html#_multisearch_example) seems uncovered. Not sure it's worth adding native test coverge for this in anoher pr.
>
> That's the `3.22.x` documentation for `elasticsearch-rest`. `elasticsearch-rest-client` is slightly different. There is no `multisearch` option.
>
> All of the routes under test use authentication, so that part is covered.
Ok, it's probably the low level rest client. And so the coverage is good. Thanks for explanation @jamesnetherton .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add elasticsearch-rest-client native support [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #6176:
URL: https://github.com/apache/camel-quarkus/pull/6176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org