You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/05 10:38:07 UTC
[GitHub] [skywalking-rust] jmjoy opened a new pull request, #25: Improve errors.
jmjoy opened a new pull request, #25:
URL: https://github.com/apache/skywalking-rust/pull/25
Using `thiserror` is the most mainstream error handling method in the Rust library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #25: Improve errors.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #25:
URL: https://github.com/apache/skywalking-rust/pull/25#issuecomment-1174914444
What is the new lib license?
We need to evaluate all licenses of dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #25: Improve errors.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #25:
URL: https://github.com/apache/skywalking-rust/pull/25#issuecomment-1174918599
And the tool `cargo-license` can list all license of dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] codecov-commenter commented on pull request #25: Improve errors.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #25:
URL: https://github.com/apache/skywalking-rust/pull/25#issuecomment-1174912567
# [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/25?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#25](https://codecov.io/gh/apache/skywalking-rust/pull/25?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1ebddf) into [master](https://codecov.io/gh/apache/skywalking-rust/commit/a047ef885e5b9dd80253c28e304dba77ea526ad6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a047ef8) will **not change** coverage.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #25 +/- ##
=======================================
Coverage 86.91% 86.91%
=======================================
Files 9 9
Lines 298 298
=======================================
Hits 259 259
Misses 39 39
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-rust/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/reporter/grpc.rs](https://codecov.io/gh/apache/skywalking-rust/pull/25/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JlcG9ydGVyL2dycGMucnM=) | `0.00% <0.00%> (ø)` | |
| [src/context/trace\_context.rs](https://codecov.io/gh/apache/skywalking-rust/pull/25/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRleHQvdHJhY2VfY29udGV4dC5ycw==) | `74.78% <66.66%> (ø)` | |
| [src/context/propagation/decoder.rs](https://codecov.io/gh/apache/skywalking-rust/pull/25/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRleHQvcHJvcGFnYXRpb24vZGVjb2Rlci5ycw==) | `91.17% <75.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/25?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/25?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a047ef8...b1ebddf](https://codecov.io/gh/apache/skywalking-rust/pull/25?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #25: Improve errors.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #25:
URL: https://github.com/apache/skywalking-rust/pull/25#issuecomment-1174917111
> What is the new lib license? We need to evaluate all licenses of dependencies.
[MIT ](https://choosealicense.com/licenses/mit)OR [Apache-2.0](https://choosealicense.com/licenses/apache-2.0)
<https://github.com/dtolnay/thiserror#license>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #25: Improve errors.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #25:
URL: https://github.com/apache/skywalking-rust/pull/25#issuecomment-1178529777
Dependencies License check by skywalking-eyes added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng merged pull request #25: Improve errors.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #25:
URL: https://github.com/apache/skywalking-rust/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #25: Improve errors.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #25:
URL: https://github.com/apache/skywalking-rust/pull/25#issuecomment-1174921476
Could you add a CI check to cross check this command result with a hosted file in the repo?
Then we could check no dependencies change in PR, and all dependencies are safe in the ASF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org