You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by maxlip <gi...@git.apache.org> on 2017/09/20 21:16:15 UTC
[GitHub] libcloud pull request #1115: [LIBCLOUD-934] Adding support for GCE node labe...
GitHub user maxlip opened a pull request:
https://github.com/apache/libcloud/pull/1115
[LIBCLOUD-934] Adding support for GCE node labels.
## Changes Title [LIBCLOUD-934] Adding support for GCE node labels.
### Description
Added the ability to set [resource labels](https://cloud.google.com/compute/docs/reference/latest/instances/setLabels
) for GCE VMs. This can be done on node/multinode creation or via new ex_set_node_labels method.
There a few relevant JIRAs, such as https://issues.apache.org/jira/browse/LIBCLOUD-934
For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
section of our documentation.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [ x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [x ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maxlip/libcloud LIBCLOUD-934_gce-node-labels
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1115
----
commit 76848e98927d3261b03d8dcba3d1dfd8a2cab9d0
Author: maxlip <ma...@gmail.com>
Date: 2017-09-20T21:09:18Z
[LIBCLOUD-934] Adding support for GCE node labels.
----
---
[GitHub] libcloud pull request #1115: [LIBCLOUD-934] Adding support for GCE node labe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/libcloud/pull/1115
---