You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/19 14:57:08 UTC

[GitHub] [incubator-mxnet] szha commented on a change in pull request #20188: [BUGFIX]try avoid the error in operator/tensor/amp_cast.h

szha commented on a change in pull request #20188:
URL: https://github.com/apache/incubator-mxnet/pull/20188#discussion_r615923064



##########
File path: 3rdparty/mshadow/mshadow/base.h
##########
@@ -1364,7 +1364,8 @@ struct minimum {
   default:                                          \
     LOG(FATAL) << "Unknown type enum " << type;     \
   }
-
+// amp_cast.h is using this MSHADOW_TYPE_SWITCH_WITH_BOOL in order to
+// avoid 'Unsupport enum type 12' error.

Review comment:
       no need to have this comment here as we don't leave comments on every usage of the macro




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org