You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/05/02 14:40:44 UTC
Re: Review Request 58263: Inherited working dir from parent when
launching a DEBUG container.
> On April 28, 2017, 8:49 p.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 1484 (patched)
> > <https://reviews.apache.org/r/58263/diff/4/?file=1703236#file1703236line1484>
> >
> > Curious if we want to allow isolators to override this behavior for debug containers just like non-debug containers.
A good question. My first thought is not, we would like DEBUG containers to have the same working directory as their parents. On the other side, I don't have enough context to understand or envision cases where an isolator would set work dir to different values for a container and its children.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review173380
-----------------------------------------------------------
On April 28, 2017, 4:14 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 4:14 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
>
>
> Bugs: MESOS-7433
> https://issues.apache.org/jira/browse/MESOS-7433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/slave/containerizer.proto c30b1fc659ee9b3cd343899638ced6408d8b51a2
> src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d
> src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 29007898ec04e922266068a8519731b13d351a82
>
>
> Diff: https://reviews.apache.org/r/58263/diff/4/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/58821/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>