[GitHub] [druid] suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #9384: Add join prefix duplicate/shadowing check
URL: https://github.com/apache/druid/pull/9384#discussion_r382871126
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/join/Joinables.java
 ##########
 @@ -114,4 +118,37 @@ public static boolean isPrefixedBy(final String columnName, final String prefix)
       );
     }).collect(Collectors.toList());
   }
+
+  public static void checkPreJoinableClausesForDuplicatesAndShadowing(
 
 Review comment:
   ```suggestion
     private static void checkPreJoinableClausesForDuplicatesAndShadowing(
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org