You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "zhoujinsong (via GitHub)" <gi...@apache.org> on 2024/07/24 07:24:20 UTC
[PR] Fix the content of NOTICE files [amoro-shade]
zhoujinsong opened a new pull request, #8:
URL: https://github.com/apache/amoro-shade/pull/8
close #7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the content of NOTICE files [amoro-shade]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #8:
URL: https://github.com/apache/amoro-shade/pull/8#discussion_r1690295277
##########
amoro-shade-zookeeper-3/src/main/resources/META-INF/NOTICE:
##########
@@ -1,8 +1,5 @@
amoro-shade-zookeeper-3
-Copyright 2014-2023 The Apache Software Foundation
Review Comment:
this copyright should be based on the copyright in the zookeeper notice
I actually think we should keep the notice from the zookeper jar and not replace it with an amoro one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the content of NOTICE files [amoro-shade]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #8:
URL: https://github.com/apache/amoro-shade/pull/8#issuecomment-2325872969
Although version 0.7.0-incubating was released without incorporating these notice improvements, we should still continue to promote the optimization of notices.
I left some ncessarry changes:
- Add incubating into the project name.
- Fix the year range of copyright.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the content of NOTICE files [amoro-shade]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #8:
URL: https://github.com/apache/amoro-shade/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix the content of NOTICE files [amoro-shade]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #8:
URL: https://github.com/apache/amoro-shade/pull/8#discussion_r1690297260
##########
amoro-shade-thrift/src/main/resources/META-INF/NOTICE:
##########
@@ -1,8 +1,5 @@
amoro-shade-thrift
-Copyright (C) 2006 - 2019, The Apache Software Foundation
Review Comment:
I think the copyright is right already and that the change is wrong
better still, we should just keep the notice from the actual thrift jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org