[GitHub] [skywalking] wu-sheng commented on a change in pull request #8408: Add faas to SpanLayer

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #8408:
URL: https://github.com/apache/skywalking/pull/8408#discussion_r782822686



##########
File path: oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/parser/listener/MultiScopesAnalysisListener.java
##########
@@ -133,7 +133,7 @@ public void parseEntry(SpanObject span, SegmentObject segmentObject) {
             sourceBuilder.setSourceNormal(false);
             sourceBuilder.setDestServiceInstanceName(segmentObject.getServiceInstance());
             sourceBuilder.setDestServiceName(segmentObject.getService());
-            sourceBuilder.setDestLayer(Layer.GENERAL);
+            sourceBuilder.setDestLayer(fromSpanLayerValue(span.getSpanLayer()));

Review comment:
       I think this is wrong for MQ case. Entry span has the MQ as layer but it represents the service itself.
   
   In my idea, you should not use `fromSpanLayerValue` directly, we just should consider `FAAS` service as a new general condition here, but all others should keep in `Layer.GNERAL`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org