[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6534: Spark 3.3: Use regular planning for applicable row-level operations

[GitBox <gi...@apache.org>]

RussellSpitzer commented on code in PR #6534:
URL: https://github.com/apache/iceberg/pull/6534#discussion_r1063736292


##########
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/RowLevelCommandScanRelationPushDown.scala:
##########
@@ -38,8 +40,15 @@ object RowLevelCommandScanRelationPushDown extends Rule[LogicalPlan] with Predic
   import ExtendedDataSourceV2Implicits._
 
   override def apply(plan: LogicalPlan): LogicalPlan = plan transformDown {
+    // use regular planning for delta-based plans and copy-on-write MERGE operations

Review Comment:
   When we say regular planning, we mean we are using Normal Spark pushdown code on the rewrite plan correct and then giving the command back to Spark? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org