You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/04/04 18:33:30 UTC

Review Request 45687: Increase timeout for forking new process

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45687/
-----------------------------------------------------------

Review request for geode, Jens Deppe and Jinmei Liao.


Bugs: GEODE-103 and GEODE-1136
    https://issues.apache.org/jira/browse/GEODE-103
    https://issues.apache.org/jira/browse/GEODE-1136


Repository: geode


Description
-------

GEODE-103: increase timeout for forking new process
GEODE-1136: increase timeout for forking new process

Increase timeout in ProcessStreamReaderTestCase from 1 minute to 5 minutes.

I don't see any obvious race conditions in the test. Failure to start within 1 minute would probably have 1 of 2 possible causes. 1) it occasionally takes more than 1 minute to fork a process on some apache infra machines, 2) there's a race condition such that the test fails to detect that the process was successfully forked. Since I don't see #2, I'll assume #1 and increase the timeout. If 5 minutes fails in the same way, then I think there must be some race condition that I don't see (if reviewers see a race condition please let me know!).


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/internal/process/ProcessStreamReaderTestCase.java 413705f 

Diff: https://reviews.apache.org/r/45687/diff/


Testing
-------


Thanks,

Kirk Lund