You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2016/04/21 06:05:09 UTC
[GitHub] tajo pull request: TAJO-2127: Use Type instead of DataType for Eva...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/1005
TAJO-2127: Use Type instead of DataType for EvalNode.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-2127
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/1005.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1005
----
commit 826aeb3dec2a087831863ec47d9616e91b15bc72
Author: Hyunsik Choi <hy...@apache.org>
Date: 2016-04-21T04:04:24Z
TAJO-2127: Use Type instead of DataType for EvalNode.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2127: Use Type instead of DataType for Eva...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/1005
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2127: Use Type instead of DataType for Eva...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/1005#issuecomment-213366641
+1 LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2127: Use Type instead of DataType for Eva...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1005#discussion_r60706629
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java ---
@@ -577,7 +577,7 @@ public static void verifyProjectedFields(QueryBlock block, Projectable projectab
public static void prohibitNestedRecordProjection(Projectable projectable)
throws TajoException {
for (Target t : projectable.getTargets()) {
- if (t.getEvalTree().getValueType().getType() == TajoDataTypes.Type.RECORD) {
+ if (t.getEvalTree().getValueType().isStruct()) {
--- End diff --
Struct or record?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2127: Use Type instead of DataType for Eva...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/1005#issuecomment-213359958
Fixed unit tests. Thank you for your quick review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2127: Use Type instead of DataType for Eva...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1005#discussion_r60709565
--- Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java ---
@@ -565,7 +565,7 @@ public void testImplicitCastForInt8() throws TajoException {
public void testImplicitCastForFloat4() throws TajoException {
Schema schema = TestSchema1;
- testEval(schema, "table1", "0,1,2,3,4.1,5.1,6,7", "select col4 + col0 from table1;", new String [] {"4.1"});
+ /*testEval(schema, "table1", "0,1,2,3,4.1,5.1,6,7", "select col4 + col0 from table1;", new String [] {"4.1"});
--- End diff --
I forget to remove the comments after some bug fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2127: Use Type instead of DataType for Eva...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1005#discussion_r60712098
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java ---
@@ -577,7 +577,7 @@ public static void verifyProjectedFields(QueryBlock block, Projectable projectab
public static void prohibitNestedRecordProjection(Projectable projectable)
throws TajoException {
for (Target t : projectable.getTargets()) {
- if (t.getEvalTree().getValueType().getType() == TajoDataTypes.Type.RECORD) {
+ if (t.getEvalTree().getValueType().isStruct()) {
--- End diff --
Ok. Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2127: Use Type instead of DataType for Eva...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1005#discussion_r60709717
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java ---
@@ -577,7 +577,7 @@ public static void verifyProjectedFields(QueryBlock block, Projectable projectab
public static void prohibitNestedRecordProjection(Projectable projectable)
throws TajoException {
for (Target t : projectable.getTargets()) {
- if (t.getEvalTree().getValueType().getType() == TajoDataTypes.Type.RECORD) {
+ if (t.getEvalTree().getValueType().isStruct()) {
--- End diff --
Currently, record is right. I need to make them consistent. According to my future plan, struct would be better. That's why they are mixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2127: Use Type instead of DataType for Eva...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1005#discussion_r60707167
--- Diff: tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java ---
@@ -565,7 +565,7 @@ public void testImplicitCastForInt8() throws TajoException {
public void testImplicitCastForFloat4() throws TajoException {
Schema schema = TestSchema1;
- testEval(schema, "table1", "0,1,2,3,4.1,5.1,6,7", "select col4 + col0 from table1;", new String [] {"4.1"});
+ /*testEval(schema, "table1", "0,1,2,3,4.1,5.1,6,7", "select col4 + col0 from table1;", new String [] {"4.1"});
--- End diff --
Why did you disable these tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---