You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/01/07 18:15:24 UTC

svn commit: r1429905 [1/26] - in /commons/proper/collections/trunk/src: main/java/org/apache/commons/collections/ main/java/org/apache/commons/collections/bag/ main/java/org/apache/commons/collections/bidimap/ main/java/org/apache/commons/collections/b...

Author: ggregory
Date: Mon Jan  7 17:15:14 2013
New Revision: 1429905

URL: http://svn.apache.org/viewvc?rev=1429905&view=rev
Log:
Where possible:
- Add final modifier to private fields
- Add final modifier to method parameters
- Add final modifier to local variables

Modified:
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ArrayStack.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BagUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferOverflowException.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferUnderflowException.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ClosureUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/CollectionUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ComparatorUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/EnumerationUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ExtendedProperties.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FactoryUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FunctorException.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/IteratorUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ListUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/MapUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/PredicateUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/SetUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/SplitMapUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/TransformerUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/TrieUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/AbstractBagDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/AbstractMapBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/AbstractSortedBagDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/HashBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/PredicatedBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/PredicatedSortedBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/SynchronizedBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/SynchronizedSortedBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/TransformedBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/TransformedSortedBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/TreeBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/UnmodifiableBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bag/UnmodifiableSortedBag.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/AbstractBidiMapDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/AbstractDualBidiMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/AbstractOrderedBidiMapDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/AbstractSortedBidiMapDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/DualHashBidiMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/DualTreeBidiMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/TreeBidiMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/UnmodifiableBidiMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/UnmodifiableOrderedBidiMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/bidimap/UnmodifiableSortedBidiMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/AbstractBufferDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/BlockingBuffer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/BoundedBuffer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/BoundedFifoBuffer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/CircularFifoBuffer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/PredicatedBuffer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/PriorityBuffer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/SynchronizedBuffer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/TransformedBuffer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/UnboundedFifoBuffer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/buffer/UnmodifiableBuffer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/AbstractCollectionDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/AbstractUntypedCollectionDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/CompositeCollection.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/IndexedCollection.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/PredicatedCollection.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/SynchronizedCollection.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/TransformedCollection.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableBoundedCollection.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableCollection.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/BooleanComparator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparableComparator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparatorChain.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/FixedOrderComparator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/NullComparator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ReverseComparator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/TransformingComparator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/DeleteCommand.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/EditCommand.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/EditScript.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/InsertCommand.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/KeepCommand.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/ReplacementsFinder.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/SequencesComparator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/Snake.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AllPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AndPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AnyPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CatchAndRethrowClosure.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ChainedClosure.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ChainedTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CloneTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ClosureTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ComparatorPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ConstantFactory.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ConstantTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/DefaultEquator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/EqualPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionClosure.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FactoryTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FalsePredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ForClosure.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FunctorUtils.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/IdentityPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/IfClosure.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/InstanceofPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/InstantiateFactory.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/InstantiateTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/InvokerTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/MapTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/NOPClosure.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/NOPTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/NonePredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/NotNullPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/NotPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/NullIsExceptionPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/NullIsFalsePredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/NullIsTruePredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/NullPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/OnePredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/OrPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/PredicateTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/PrototypeFactory.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/StringValueTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/SwitchClosure.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/SwitchTransformer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/TransformedPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/TransformerClosure.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/TransformerPredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/TruePredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/UniquePredicate.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/WhileClosure.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/AbstractEmptyIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/AbstractEmptyMapIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/AbstractIteratorDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/AbstractListIteratorDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/AbstractMapIteratorDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/AbstractOrderedMapIteratorDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/AbstractUntypedIteratorDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/ArrayListIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/CollatingIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/EntrySetMapIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/FilterIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/FilterListIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/IteratorChain.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/IteratorEnumeration.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/IteratorIterable.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/ListIteratorWrapper.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/LoopingIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/LoopingListIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/ObjectArrayIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/ObjectArrayListIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/ObjectGraphIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/ReverseListIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/SingletonIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/SingletonListIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/TransformIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/UniqueFilterIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/UnmodifiableIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/UnmodifiableListIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/UnmodifiableMapIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/iterators/UnmodifiableOrderedMapIterator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/keyvalue/AbstractKeyValue.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/keyvalue/AbstractMapEntry.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/keyvalue/AbstractMapEntryDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/keyvalue/DefaultKeyValue.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/keyvalue/MultiKey.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/keyvalue/TiedMapEntry.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/keyvalue/UnmodifiableMapEntry.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/AbstractLinkedList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/AbstractListDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/AbstractSerializableListDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/CursorableLinkedList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/FixedSizeList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/GrowthList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/LazyList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/NodeCachingLinkedList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/PredicatedList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/SetUniqueList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/SynchronizedList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/TransformedList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/TreeList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/list/UnmodifiableList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/AbstractHashedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/AbstractInputCheckedMapDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/AbstractLinkedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/AbstractMapDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/AbstractOrderedMapDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/AbstractReferenceMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/AbstractSortedMapDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/CaseInsensitiveMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/CompositeMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/DefaultedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/EntrySetToMapIteratorAdapter.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/FixedSizeMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/FixedSizeSortedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/Flat3Map.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/HashedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/IdentityMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/LRUMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/LazyMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/LazySortedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/LinkedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/ListOrderedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/MultiKeyMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/MultiValueMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/PassiveExpiringMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/PredicatedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/PredicatedSortedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/ReferenceIdentityMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/ReferenceMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/SingletonMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/StaticBucketMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/TransformedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/TransformedSortedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/UnmodifiableEntrySet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/UnmodifiableMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/UnmodifiableOrderedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/map/UnmodifiableSortedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/AbstractSerializableSetDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/AbstractSetDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/AbstractSortedSetDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/ListOrderedSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/MapBackedSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/PredicatedSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/PredicatedSortedSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/SynchronizedSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/SynchronizedSortedSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/TransformedSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/TransformedSortedSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/UnmodifiableSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/UnmodifiableSortedSet.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/splitmap/AbstractIterableGetMapDecorator.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/splitmap/TransformedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/AbstractKeyAnalyzer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/AbstractTrie.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/ByteArrayKeyAnalyzer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/ByteKeyAnalyzer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/CharArrayKeyAnalyzer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/CharacterKeyAnalyzer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/IntegerKeyAnalyzer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/LongKeyAnalyzer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/PatriciaTrie.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/PatriciaTrieBase.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/ShortKeyAnalyzer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/StringKeyAnalyzer.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/SynchronizedTrie.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/trie/UnmodifiableTrie.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/AbstractArrayListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/AbstractLinkedListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/AbstractObjectTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/AbstractTreeMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/AbstractTypedCollectionTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/ArrayStackTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/BagUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/BufferUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/BulkTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/ClosureUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/EnumerationUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/ExtendedPropertiesTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/FactoryUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/IteratorUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/ListUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/MapPerformance.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/MapUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/MockTestCase.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/PredicateUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/SetUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/SplitMapUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/TestUtils.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/TransformerUtilsTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bag/AbstractBagTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bag/AbstractSortedBagTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bag/HashBagTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bag/PredicatedBagTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bag/PredicatedSortedBagTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bag/TransformedBagTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bag/TransformedSortedBagTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bag/TreeBagTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/AbstractBidiMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/AbstractOrderedBidiMapDecoratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/AbstractOrderedBidiMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/AbstractSortedBidiMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/DualHashBidiMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/DualTreeBidiMap2Test.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/DualTreeBidiMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/TreeBidiMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/UnmodifiableBidiMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/UnmodifiableOrderedBidiMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/bidimap/UnmodifiableSortedBidiMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/BlockingBufferTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/BoundedBufferTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/BoundedFifoBuffer2Test.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/BoundedFifoBufferTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/CircularFifoBufferTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/PredicatedBufferTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/PriorityBufferTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/SynchronizedBufferTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/TransformedBufferTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/UnboundedFifoBufferTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/buffer/UnmodifiableBufferTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/collection/AbstractCollectionTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/collection/CompositeCollectionTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/collection/IndexedCollectionTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/collection/PredicatedCollectionTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/collection/SynchronizedCollectionTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/collection/TransformedCollectionTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/collection/UnmodifiableBoundedCollectionTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/collection/UnmodifiableCollectionTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/comparators/AbstractComparatorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/comparators/AbstractNullComparatorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/comparators/BooleanComparatorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/comparators/ComparableComparatorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/comparators/ComparatorChainTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/comparators/FixedOrderComparatorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/comparators/ReverseComparatorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/comparators/TransformingComparatorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/comparators/sequence/SequencesComparatorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/AbstractClosureTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/AbstractCompositePredicateTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/AbstractMockPredicateTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/AbstractPredicateTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/CatchAndRethrowClosureTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/ComparatorPredicateTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/EqualPredicateTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/functors/NullPredicateTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/AbstractIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/AbstractListIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/AbstractMapIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/AbstractOrderedMapIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ArrayIterator2Test.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ArrayIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ArrayListIterator2Test.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ArrayListIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/CollatingIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/FilterIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/FilterListIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/IteratorChainTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/IteratorIterableTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ListIteratorWrapper2Test.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ListIteratorWrapperTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/LoopingIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/LoopingListIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ObjectArrayIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ObjectArrayListIterator2Test.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ObjectArrayListIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ObjectGraphIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/ReverseListIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/SingletonIterator2Test.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/SingletonIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/SingletonListIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/UniqueFilterIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/UnmodifiableIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/UnmodifiableListIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/UnmodifiableMapIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/iterators/UnmodifiableOrderedMapIteratorTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/keyvalue/AbstractMapEntryTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/keyvalue/DefaultKeyValueTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/keyvalue/DefaultMapEntryTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/keyvalue/MultiKeyTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/keyvalue/TiedMapEntryTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/keyvalue/UnmodifiableMapEntryTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/AbstractLinkedListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/AbstractListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/CursorableLinkedListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/FixedSizeListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/GrowthListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/NodeCachingLinkedListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/PredicatedListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/SetUniqueListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/SynchronizedListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/TransformedListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/TreeListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/list/UnmodifiableListTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/AbstractIterableMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/AbstractMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/AbstractOrderedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/AbstractSortedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/CaseInsensitiveMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/CompositeMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/DefaultedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/EmptyMapMutator.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/FixedSizeMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/FixedSizeSortedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/Flat3MapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/HashedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/IdentityMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/LRUMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/LazyMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/LazySortedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/LinkedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/ListOrderedMap2Test.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/ListOrderedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/MultiKeyMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/MultiValueMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/PassiveExpiringMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/PredicatedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/PredicatedSortedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/ReferenceIdentityMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/ReferenceMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/SingletonMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/StaticBucketMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/TransformedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/TransformedSortedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/UnmodifiableMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/UnmodifiableOrderedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/map/UnmodifiableSortedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/AbstractSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/AbstractSortedSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/CompositeSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/EmptySetMutator.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/ListOrderedSet2Test.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/ListOrderedSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/MapBackedSet2Test.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/MapBackedSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/PredicatedSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/PredicatedSortedSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/SynchronizedSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/SynchronizedSortedSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/TransformedSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/TransformedSortedSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/UnmodifiableSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/set/UnmodifiableSortedSetTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/splitmap/TransformedMapTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/trie/ByteArrayKeyAnalyzerTest.java
    commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/trie/PatriciaTrieTest.java

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ArrayStack.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ArrayStack.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ArrayStack.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ArrayStack.java Mon Jan  7 17:15:14 2013
@@ -58,7 +58,7 @@ public class ArrayStack<E> extends Array
      * @throws IllegalArgumentException  if the specified initial size
      *  is negative
      */
-    public ArrayStack(int initialSize) {
+    public ArrayStack(final int initialSize) {
         super(initialSize);
     }
 
@@ -81,7 +81,7 @@ public class ArrayStack<E> extends Array
      * @throws EmptyStackException  if the stack is empty
      */
     public E peek() throws EmptyStackException {
-        int n = size();
+        final int n = size();
         if (n <= 0) {
             throw new EmptyStackException();
         } else {
@@ -98,8 +98,8 @@ public class ArrayStack<E> extends Array
      * @throws EmptyStackException  if there are not enough items on the
      *  stack to satisfy this request
      */
-    public E peek(int n) throws EmptyStackException {
-        int m = (size() - n) - 1;
+    public E peek(final int n) throws EmptyStackException {
+        final int m = (size() - n) - 1;
         if (m < 0) {
             throw new EmptyStackException();
         } else {
@@ -114,7 +114,7 @@ public class ArrayStack<E> extends Array
      * @throws EmptyStackException  if the stack is empty
      */
     public E pop() throws EmptyStackException {
-        int n = size();
+        final int n = size();
         if (n <= 0) {
             throw new EmptyStackException();
         } else {
@@ -129,7 +129,7 @@ public class ArrayStack<E> extends Array
      * @param item  the item to be added
      * @return the item just pushed
      */
-    public E push(E item) {
+    public E push(final E item) {
         add(item);
         return item;
     }
@@ -145,11 +145,11 @@ public class ArrayStack<E> extends Array
      * @param object  the object to be searched for
      * @return the 1-based depth into the stack of the object, or -1 if not found
      */
-    public int search(Object object) {
+    public int search(final Object object) {
         int i = size() - 1;        // Current index
         int n = 1;                 // Current distance
         while (i >= 0) {
-            Object current = get(i);
+            final Object current = get(i);
             if ((object == null && current == null) ||
                 (object != null && object.equals(current))) {
                 return n;
@@ -167,7 +167,7 @@ public class ArrayStack<E> extends Array
      * @throws BufferUnderflowException  if the stack is empty
      */
     public E get() {
-        int size = size();
+        final int size = size();
         if (size == 0) {
             throw new BufferUnderflowException();
         }
@@ -181,7 +181,7 @@ public class ArrayStack<E> extends Array
      * @throws BufferUnderflowException  if the stack is empty
      */
     public E remove() {
-        int size = size();
+        final int size = size();
         if (size == 0) {
             throw new BufferUnderflowException();
         }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BagUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BagUtils.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BagUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BagUtils.java Mon Jan  7 17:15:14 2013
@@ -80,7 +80,7 @@ public class BagUtils {
      * @return a synchronized bag backed by that bag
      * @throws IllegalArgumentException if the Bag is null
      */
-    public static <E> Bag<E> synchronizedBag(Bag<E> bag) {
+    public static <E> Bag<E> synchronizedBag(final Bag<E> bag) {
         return SynchronizedBag.synchronizedBag(bag);
     }
 
@@ -93,7 +93,7 @@ public class BagUtils {
      * @return an unmodifiable view of that bag
      * @throws IllegalArgumentException if the Bag is null
      */
-    public static <E> Bag<E> unmodifiableBag(Bag<E> bag) {
+    public static <E> Bag<E> unmodifiableBag(final Bag<E> bag) {
         return UnmodifiableBag.unmodifiableBag(bag);
     }
 
@@ -112,7 +112,7 @@ public class BagUtils {
      * @return a predicated bag backed by the given bag
      * @throws IllegalArgumentException if the Bag or Predicate is null
      */
-    public static <E> Bag<E> predicatedBag(Bag<E> bag, Predicate<? super E> predicate) {
+    public static <E> Bag<E> predicatedBag(final Bag<E> bag, final Predicate<? super E> predicate) {
         return PredicatedBag.predicatedBag(bag, predicate);
     }
 
@@ -132,7 +132,7 @@ public class BagUtils {
      * @return a transformed bag backed by the given bag
      * @throws IllegalArgumentException if the Bag or Transformer is null
      */
-    public static <E> Bag<E> transformingBag(Bag<E> bag, Transformer<? super E, ? extends E> transformer) {
+    public static <E> Bag<E> transformingBag(final Bag<E> bag, final Transformer<? super E, ? extends E> transformer) {
         return TransformedBag.transformingBag(bag, transformer);
     }
 
@@ -163,7 +163,7 @@ public class BagUtils {
      * @return a synchronized bag backed by that bag
      * @throws IllegalArgumentException if the SortedBag is null
      */
-    public static <E> SortedBag<E> synchronizedSortedBag(SortedBag<E> bag) {
+    public static <E> SortedBag<E> synchronizedSortedBag(final SortedBag<E> bag) {
         return SynchronizedSortedBag.synchronizedSortedBag(bag);
     }
 
@@ -177,7 +177,7 @@ public class BagUtils {
      * @return an unmodifiable view of that bag
      * @throws IllegalArgumentException if the SortedBag is null
      */
-    public static <E> SortedBag<E> unmodifiableSortedBag(SortedBag<E> bag) {
+    public static <E> SortedBag<E> unmodifiableSortedBag(final SortedBag<E> bag) {
         return UnmodifiableSortedBag.unmodifiableSortedBag(bag);
     }
 
@@ -197,8 +197,8 @@ public class BagUtils {
      * @return a predicated bag backed by the given bag
      * @throws IllegalArgumentException if the SortedBag or Predicate is null
      */
-    public static <E> SortedBag<E> predicatedSortedBag(SortedBag<E> bag,
-            Predicate<? super E> predicate) {
+    public static <E> SortedBag<E> predicatedSortedBag(final SortedBag<E> bag,
+            final Predicate<? super E> predicate) {
         return PredicatedSortedBag.predicatedSortedBag(bag, predicate);
     }
 
@@ -219,8 +219,8 @@ public class BagUtils {
      * @return a transformed bag backed by the given bag
      * @throws IllegalArgumentException if the Bag or Transformer is null
      */
-    public static <E> SortedBag<E> transformingSortedBag(SortedBag<E> bag,
-                                                         Transformer<? super E, ? extends E> transformer) {
+    public static <E> SortedBag<E> transformingSortedBag(final SortedBag<E> bag,
+                                                         final Transformer<? super E, ? extends E> transformer) {
         return TransformedSortedBag.transformingSortedBag(bag, transformer);
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferOverflowException.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferOverflowException.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferOverflowException.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferOverflowException.java Mon Jan  7 17:15:14 2013
@@ -40,7 +40,7 @@ public class BufferOverflowException ext
      * 
      * @param message  the detail message for this exception
      */
-    public BufferOverflowException(String message) {
+    public BufferOverflowException(final String message) {
         this(message, null);
     }
 
@@ -50,7 +50,7 @@ public class BufferOverflowException ext
      * @param message  the detail message for this exception
      * @param exception  the root cause of the exception
      */
-    public BufferOverflowException(String message, Throwable exception) {
+    public BufferOverflowException(final String message, final Throwable exception) {
         super(message, exception);
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferUnderflowException.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferUnderflowException.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferUnderflowException.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferUnderflowException.java Mon Jan  7 17:15:14 2013
@@ -43,7 +43,7 @@ public class BufferUnderflowException ex
      * 
      * @param message  the detail message for this exception
      */
-    public BufferUnderflowException(String message) {
+    public BufferUnderflowException(final String message) {
         super(message);
     }
 
@@ -53,7 +53,7 @@ public class BufferUnderflowException ex
      * @param message  the detail message for this exception
      * @param exception  the root cause of the exception
      */
-    public BufferUnderflowException(String message, Throwable exception) {
+    public BufferUnderflowException(final String message, final Throwable exception) {
         super(message);
         initCause(exception);
     }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferUtils.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/BufferUtils.java Mon Jan  7 17:15:14 2013
@@ -64,7 +64,7 @@ public class BufferUtils {
      * @return a synchronized buffer backed by that buffer
      * @throws IllegalArgumentException  if the Buffer is null
      */
-    public static <E> Buffer<E> synchronizedBuffer(Buffer<E> buffer) {
+    public static <E> Buffer<E> synchronizedBuffer(final Buffer<E> buffer) {
         return SynchronizedBuffer.synchronizedBuffer(buffer);
     }
 
@@ -81,7 +81,7 @@ public class BufferUtils {
      * @return a blocking buffer backed by that buffer
      * @throws IllegalArgumentException  if the Buffer is null
      */
-    public static <E> Buffer<E> blockingBuffer(Buffer<E> buffer) {
+    public static <E> Buffer<E> blockingBuffer(final Buffer<E> buffer) {
         return BlockingBuffer.blockingBuffer(buffer);
     }
 
@@ -100,7 +100,7 @@ public class BufferUtils {
      * @throws IllegalArgumentException  if the Buffer is null
      * @since 3.2
      */
-    public static <E> Buffer<E> blockingBuffer(Buffer<E> buffer, long timeoutMillis) {
+    public static <E> Buffer<E> blockingBuffer(final Buffer<E> buffer, final long timeoutMillis) {
         return BlockingBuffer.blockingBuffer(buffer, timeoutMillis);
     }
 
@@ -118,7 +118,7 @@ public class BufferUtils {
      * @throws IllegalArgumentException if the given buffer is null
      * @since 3.2
      */
-    public static <E> Buffer<E> boundedBuffer(Buffer<E> buffer, int maximumSize) {
+    public static <E> Buffer<E> boundedBuffer(final Buffer<E> buffer, final int maximumSize) {
         return BoundedBuffer.boundedBuffer(buffer, maximumSize);
     }
 
@@ -137,7 +137,7 @@ public class BufferUtils {
      * @throws IllegalArgumentException if the given buffer is null
      * @since 3.2
      */
-    public static <E> Buffer<E> boundedBuffer(Buffer<E> buffer, int maximumSize, long timeoutMillis) {
+    public static <E> Buffer<E> boundedBuffer(final Buffer<E> buffer, final int maximumSize, final long timeoutMillis) {
         return BoundedBuffer.boundedBuffer(buffer, maximumSize, timeoutMillis);
     }
 
@@ -149,7 +149,7 @@ public class BufferUtils {
      * @return an unmodifiable buffer backed by that buffer
      * @throws IllegalArgumentException  if the Buffer is null
      */
-    public static <E> Buffer<E> unmodifiableBuffer(Buffer<E> buffer) {
+    public static <E> Buffer<E> unmodifiableBuffer(final Buffer<E> buffer) {
         return UnmodifiableBuffer.unmodifiableBuffer(buffer);
     }
 
@@ -167,7 +167,7 @@ public class BufferUtils {
      * @return a predicated buffer
      * @throws IllegalArgumentException  if the Buffer or Predicate is null
      */
-    public static <E> Buffer<E> predicatedBuffer(Buffer<E> buffer, Predicate<? super E> predicate) {
+    public static <E> Buffer<E> predicatedBuffer(final Buffer<E> buffer, final Predicate<? super E> predicate) {
         return PredicatedBuffer.predicatedBuffer(buffer, predicate);
     }
 
@@ -187,7 +187,7 @@ public class BufferUtils {
      * @return a transformed buffer backed by the given buffer
      * @throws IllegalArgumentException  if the Buffer or Transformer is null
      */
-    public static <E> Buffer<E> transformingBuffer(Buffer<E> buffer, Transformer<? super E, ? extends E> transformer) {
+    public static <E> Buffer<E> transformingBuffer(final Buffer<E> buffer, final Transformer<? super E, ? extends E> transformer) {
         return TransformedBuffer.transformingBuffer(buffer, transformer);
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ClosureUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ClosureUtils.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ClosureUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ClosureUtils.java Mon Jan  7 17:15:14 2013
@@ -93,7 +93,7 @@ public class ClosureUtils {
      * @param transformer  the transformer to run each time in the closure, null means nop
      * @return the closure
      */
-    public static <E> Closure<E> asClosure(Transformer<? super E, ?> transformer) {
+    public static <E> Closure<E> asClosure(final Transformer<? super E, ?> transformer) {
         return TransformerClosure.transformerClosure(transformer);
     }
 
@@ -108,7 +108,7 @@ public class ClosureUtils {
      * @param closure  the closure to call repeatedly
      * @return the <code>for</code> closure
      */
-    public static <E> Closure<E> forClosure(int count, Closure<? super E> closure) {
+    public static <E> Closure<E> forClosure(final int count, final Closure<? super E> closure) {
         return ForClosure.forClosure(count, closure);
     }
 
@@ -123,7 +123,7 @@ public class ClosureUtils {
      * @return the <code>while</code> closure
      * @throws IllegalArgumentException if either argument is null
      */
-    public static <E> Closure<E> whileClosure(Predicate<? super E> predicate, Closure<? super E> closure) {
+    public static <E> Closure<E> whileClosure(final Predicate<? super E> predicate, final Closure<? super E> closure) {
         return WhileClosure.<E>whileClosure(predicate, closure, false);
     }
 
@@ -138,7 +138,7 @@ public class ClosureUtils {
      * @return the <code>do-while</code> closure
      * @throws IllegalArgumentException if either argument is null
      */
-    public static <E> Closure<E> doWhileClosure(Closure<? super E> closure, Predicate<? super E> predicate) {
+    public static <E> Closure<E> doWhileClosure(final Closure<? super E> closure, final Predicate<? super E> predicate) {
         return WhileClosure.<E>whileClosure(predicate, closure, true);
     }
 
@@ -153,7 +153,7 @@ public class ClosureUtils {
      * @return the <code>invoker</code> closure
      * @throws IllegalArgumentException if the method name is null
      */
-    public static <E> Closure<E> invokerClosure(String methodName) {
+    public static <E> Closure<E> invokerClosure(final String methodName) {
         // reuse transformer as it has caching - this is lazy really, should have inner class here
         return asClosure(InvokerTransformer.<E, Object>invokerTransformer(methodName));
     }
@@ -172,7 +172,7 @@ public class ClosureUtils {
      * @throws IllegalArgumentException if the method name is null
      * @throws IllegalArgumentException if the paramTypes and args don't match
      */
-    public static <E> Closure<E> invokerClosure(String methodName, Class<?>[] paramTypes, Object[] args) {
+    public static <E> Closure<E> invokerClosure(final String methodName, final Class<?>[] paramTypes, final Object[] args) {
         // reuse transformer as it has caching - this is lazy really, should have inner class here
         return asClosure(InvokerTransformer.<E, Object>invokerTransformer(methodName, paramTypes, args));
     }
@@ -188,7 +188,7 @@ public class ClosureUtils {
      * @return the <code>chained</code> closure
      * @throws IllegalArgumentException if either closure is null
      */
-    public static <E> Closure<E> chainedClosure(Closure<? super E> closure1, Closure<? super E> closure2) {
+    public static <E> Closure<E> chainedClosure(final Closure<? super E> closure1, final Closure<? super E> closure2) {
         return ChainedClosure.<E>chainedClosure(closure1, closure2);
     }
 
@@ -203,7 +203,7 @@ public class ClosureUtils {
      * @throws IllegalArgumentException if the closures array is null
      * @throws IllegalArgumentException if any closure in the array is null
      */
-    public static <E> Closure<E> chainedClosure(Closure<? super E>... closures) {
+    public static <E> Closure<E> chainedClosure(final Closure<? super E>... closures) {
         return ChainedClosure.chainedClosure(closures);
     }
 
@@ -220,7 +220,7 @@ public class ClosureUtils {
      * @throws IllegalArgumentException if the closures collection is empty
      * @throws IllegalArgumentException if any closure in the collection is null
      */
-    public static <E> Closure<E> chainedClosure(Collection<Closure<E>> closures) {
+    public static <E> Closure<E> chainedClosure(final Collection<Closure<E>> closures) {
         return ChainedClosure.chainedClosure(closures);
     }
 
@@ -237,7 +237,7 @@ public class ClosureUtils {
      * @throws IllegalArgumentException if the closure is null
      * @since 3.2
      */
-    public static <E> Closure<E> ifClosure(Predicate<? super E> predicate, Closure<? super E> trueClosure) {
+    public static <E> Closure<E> ifClosure(final Predicate<? super E> predicate, final Closure<? super E> trueClosure) {
         return IfClosure.<E>ifClosure(predicate, trueClosure);
     }
 
@@ -254,9 +254,9 @@ public class ClosureUtils {
      * @throws IllegalArgumentException if the predicate is null
      * @throws IllegalArgumentException if either closure is null
      */
-    public static <E> Closure<E> ifClosure(Predicate<? super E> predicate,
-                                           Closure<? super E> trueClosure,
-                                           Closure<? super E> falseClosure) {
+    public static <E> Closure<E> ifClosure(final Predicate<? super E> predicate,
+                                           final Closure<? super E> trueClosure,
+                                           final Closure<? super E> falseClosure) {
         return IfClosure.<E>ifClosure(predicate, trueClosure, falseClosure);
     }
 
@@ -277,7 +277,7 @@ public class ClosureUtils {
      * @throws IllegalArgumentException if any element in the arrays is null
      * @throws IllegalArgumentException if the arrays are different sizes
      */
-    public static <E> Closure<E> switchClosure(Predicate<? super E>[] predicates, Closure<? super E>[] closures) {
+    public static <E> Closure<E> switchClosure(final Predicate<? super E>[] predicates, final Closure<? super E>[] closures) {
         return SwitchClosure.<E>switchClosure(predicates, closures, null);
     }
 
@@ -300,9 +300,9 @@ public class ClosureUtils {
      * @throws IllegalArgumentException if any element in the arrays is null
      * @throws IllegalArgumentException if the arrays are different sizes
      */
-    public static <E> Closure<E> switchClosure(Predicate<? super E>[] predicates,
-                                               Closure<? super E>[] closures,
-                                               Closure<? super E> defaultClosure) {
+    public static <E> Closure<E> switchClosure(final Predicate<? super E>[] predicates,
+                                               final Closure<? super E>[] closures,
+                                               final Closure<? super E> defaultClosure) {
         return SwitchClosure.<E>switchClosure(predicates, closures, defaultClosure);
     }
     
@@ -326,7 +326,7 @@ public class ClosureUtils {
      * @throws IllegalArgumentException if any closure in the map is null
      * @throws ClassCastException  if the map elements are of the wrong type
      */
-    public static <E> Closure<E> switchClosure(Map<Predicate<E>, Closure<E>> predicatesAndClosures) {
+    public static <E> Closure<E> switchClosure(final Map<Predicate<E>, Closure<E>> predicatesAndClosures) {
         return SwitchClosure.switchClosure(predicatesAndClosures);
     }
 
@@ -348,18 +348,18 @@ public class ClosureUtils {
      * @throws IllegalArgumentException if any closure in the map is null
      */
     @SuppressWarnings("unchecked")
-    public static <E> Closure<E> switchMapClosure(Map<? extends E, Closure<E>> objectsAndClosures) {
+    public static <E> Closure<E> switchMapClosure(final Map<? extends E, Closure<E>> objectsAndClosures) {
         Closure<? super E>[] trs = null;
         Predicate<E>[] preds = null;
         if (objectsAndClosures == null) {
             throw new IllegalArgumentException("The object and closure map must not be null");
         }
-        Closure<? super E> def = objectsAndClosures.remove(null);
-        int size = objectsAndClosures.size();
+        final Closure<? super E> def = objectsAndClosures.remove(null);
+        final int size = objectsAndClosures.size();
         trs = new Closure[size];
         preds = new Predicate[size];
         int i = 0;
-        for (Map.Entry<? extends E, Closure<E>> entry : objectsAndClosures.entrySet()) {
+        for (final Map.Entry<? extends E, Closure<E>> entry : objectsAndClosures.entrySet()) {
             preds[i] = EqualPredicate.<E>equalPredicate(entry.getKey());
             trs[i] = entry.getValue();
             i++;