[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #6015: system_use column is not part of disk offering

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #6015:
URL: https://github.com/apache/cloudstack/pull/6015#discussion_r811222208



##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2932,10 +2932,7 @@
                 if (account.getType() == Account.ACCOUNT_TYPE_NORMAL) {
                     throw new InvalidParameterValueException("Only ROOT admins and Domain admins can list disk offerings with isrecursive=true");
                 }
-            } else { // domain + all ancestors
-                sc.addAnd("systemUse", SearchCriteria.Op.EQ, false); // non-root users should not see system offering at all

Review comment:
       this is moved to service/compute offering, not needed while listing disk offerings.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org