You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by aldaris <gi...@git.apache.org> on 2018/08/01 08:33:29 UTC
[GitHub] wicket pull request #288: Fix JavaDoc warnings in wicket-util
GitHub user aldaris opened a pull request:
https://github.com/apache/wicket/pull/288
Fix JavaDoc warnings in wicket-util
Starting small with contributions :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aldaris/wicket javadoc-fixes-util
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #288
----
commit 971dd547f9f195db0b5696c59460eab91e506353
Author: Peter Major <pe...@...>
Date: 2018-08-01T08:32:06Z
Fix JavaDoc warnings in wicket-util
----
---
[GitHub] wicket pull request #288: Fix JavaDoc warnings in wicket-util
Posted by aldaris <gi...@git.apache.org>.
Github user aldaris commented on a diff in the pull request:
https://github.com/apache/wicket/pull/288#discussion_r206809268
--- Diff: wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java ---
@@ -22,7 +22,7 @@
* Provides Base64 encoding and decoding with URL and filename safe alphabet as defined by RFC 3548,
* section 4.
* <p/>
- * This Base64 encoder is modified to meet URL requirements. The changes are: '+' => '*', '/' =>
+ * This Base64 encoder is modified to meet URL requirements. The changes are: '+' => '*', '/' =>
* '-', and no padding.
* <p/>
--- End diff --
Should be fixed now
---
[GitHub] wicket pull request #288: Fix JavaDoc warnings in wicket-util
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/288
---
[GitHub] wicket pull request #288: Fix JavaDoc warnings in wicket-util
Posted by solomax <gi...@git.apache.org>.
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/288#discussion_r206803641
--- Diff: wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java ---
@@ -22,7 +22,7 @@
* Provides Base64 encoding and decoding with URL and filename safe alphabet as defined by RFC 3548,
* section 4.
* <p/>
- * This Base64 encoder is modified to meet URL requirements. The changes are: '+' => '*', '/' =>
+ * This Base64 encoder is modified to meet URL requirements. The changes are: '+' => '*', '/' =>
* '-', and no padding.
* <p/>
--- End diff --
this `<p/>` tag is really weird :(
---
[GitHub] wicket issue #288: Fix JavaDoc warnings in wicket-util
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/288
This PR has been merged.
Thanks a lot for the changes!
---