You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/07/27 22:55:01 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24828: don't merge saving this
codecov[bot] commented on PR #24828:
URL: https://github.com/apache/superset/pull/24828#issuecomment-1654685047
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24828?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24828](https://app.codecov.io/gh/apache/superset/pull/24828?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (899958d) into [master](https://app.codecov.io/gh/apache/superset/commit/a1396d00aabac71b8f7c3d02ad7fd953192b3643?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a1396d0) will **increase** coverage by `11.10%`.
> Report is 1 commits behind head on master.
> The diff coverage is `30.61%`.
> :exclamation: Current head 899958d differs from pull request most recent head 5611d25. Consider uploading reports for the commit 5611d25 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24828 +/- ##
===========================================
+ Coverage 55.42% 66.52% +11.10%
===========================================
Files 1903 1903
Lines 74087 74099 +12
Branches 8194 8194
===========================================
+ Hits 41061 49293 +8232
+ Misses 30905 22685 -8220
Partials 2121 2121
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `54.10% <30.61%> (?)` | |
| presto | `54.00% <30.61%> (?)` | |
| python | `78.18% <30.61%> (+23.21%)` | :arrow_up: |
| sqlite | `77.81% <30.61%> (?)` | |
| unit | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/superset/pull/24828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/daos/tag.py](https://app.codecov.io/gh/apache/superset/pull/24828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFvcy90YWcucHk=) | `88.33% <18.18%> (+39.70%)` | :arrow_up: |
| [superset/tags/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/24828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdGFncy9jb21tYW5kcy9jcmVhdGUucHk=) | `54.71% <19.04%> (+17.21%)` | :arrow_up: |
| [superset/tags/api.py](https://app.codecov.io/gh/apache/superset/pull/24828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdGFncy9hcGkucHk=) | `72.12% <42.85%> (+17.21%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://app.codecov.io/gh/apache/superset/pull/24828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.94% <100.00%> (+31.46%)` | :arrow_up: |
| [superset/connectors/sqla/utils.py](https://app.codecov.io/gh/apache/superset/pull/24828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `91.46% <100.00%> (+52.33%)` | :arrow_up: |
... and [357 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24828/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org