You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Alan Hudson (JIRA)" <ji...@apache.org> on 2012/05/23 02:22:40 UTC
[jira] [Created] (AMQ-3857) MessageServlet get messages does not
return JMS Message Properties
Alan Hudson created AMQ-3857:
--------------------------------
Summary: MessageServlet get messages does not return JMS Message Properties
Key: AMQ-3857
URL: https://issues.apache.org/jira/browse/AMQ-3857
Project: ActiveMQ
Issue Type: Bug
Components: Broker
Affects Versions: 5.6.0, 5.5.0
Reporter: Alan Hudson
When using GET to get a message it does not return any of the JMS message properties.
I can easily see how to add that code, but I'm not sure what the correct way to return them is. They could go into the response headers via setResponseHeaders or the returned XML format could be changed to support properties and the header. Sadly this would likely break most existing clients.
We'd like to use the REST API to enable some web clients to fully participate in a messaging system that is primarily Java based.
If we can come to agreement on how we want to return properties then I'd be happy to code up a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3857) MessageServlet get messages does not
return JMS Message Properties
Posted by "Alan Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Hudson updated AMQ-3857:
-----------------------------
Attachment: amq-3857.patch
junit test confirming header delivery of JMS properties.
> MessageServlet get messages does not return JMS Message Properties
> ------------------------------------------------------------------
>
> Key: AMQ-3857
> URL: https://issues.apache.org/jira/browse/AMQ-3857
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.5.0, 5.6.0
> Reporter: Alan Hudson
> Attachments: amq-3857.patch, amq-3857.patch
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> When using GET to get a message it does not return any of the JMS message properties.
> I can easily see how to add that code, but I'm not sure what the correct way to return them is. They could go into the response headers via setResponseHeaders or the returned XML format could be changed to support properties and the header. Sadly this would likely break most existing clients.
> We'd like to use the REST API to enable some web clients to fully participate in a messaging system that is primarily Java based.
> If we can come to agreement on how we want to return properties then I'd be happy to code up a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3857) MessageServlet get messages does not
return JMS Message Properties
Posted by "Alan Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284534#comment-13284534 ]
Alan Hudson commented on AMQ-3857:
----------------------------------
Looking around I see that HornetQ has a REST api as well. They return the JMS property values as headers. This looks reasonable to me and shouldn't break any existing clients using this api. I'll attach a proposed change to support this.
> MessageServlet get messages does not return JMS Message Properties
> ------------------------------------------------------------------
>
> Key: AMQ-3857
> URL: https://issues.apache.org/jira/browse/AMQ-3857
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.5.0, 5.6.0
> Reporter: Alan Hudson
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> When using GET to get a message it does not return any of the JMS message properties.
> I can easily see how to add that code, but I'm not sure what the correct way to return them is. They could go into the response headers via setResponseHeaders or the returned XML format could be changed to support properties and the header. Sadly this would likely break most existing clients.
> We'd like to use the REST API to enable some web clients to fully participate in a messaging system that is primarily Java based.
> If we can come to agreement on how we want to return properties then I'd be happy to code up a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-3857) MessageServlet get messages does not
return JMS Message Properties
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQ-3857.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.7.0
Assignee: Timothy Bish
Using the response headers seems sensible. Applied the patch and supplied test case, thanks!
> MessageServlet get messages does not return JMS Message Properties
> ------------------------------------------------------------------
>
> Key: AMQ-3857
> URL: https://issues.apache.org/jira/browse/AMQ-3857
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.5.0, 5.6.0
> Reporter: Alan Hudson
> Assignee: Timothy Bish
> Fix For: 5.7.0
>
> Attachments: amq-3857.patch, amq-3857.patch
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> When using GET to get a message it does not return any of the JMS message properties.
> I can easily see how to add that code, but I'm not sure what the correct way to return them is. They could go into the response headers via setResponseHeaders or the returned XML format could be changed to support properties and the header. Sadly this would likely break most existing clients.
> We'd like to use the REST API to enable some web clients to fully participate in a messaging system that is primarily Java based.
> If we can come to agreement on how we want to return properties then I'd be happy to code up a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3857) MessageServlet get messages does not
return JMS Message Properties
Posted by "Alan Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Hudson updated AMQ-3857:
-----------------------------
Attachment: amq-3857.patch
Patch for including JMS properties into the response headers.
> MessageServlet get messages does not return JMS Message Properties
> ------------------------------------------------------------------
>
> Key: AMQ-3857
> URL: https://issues.apache.org/jira/browse/AMQ-3857
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.5.0, 5.6.0
> Reporter: Alan Hudson
> Attachments: amq-3857.patch
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> When using GET to get a message it does not return any of the JMS message properties.
> I can easily see how to add that code, but I'm not sure what the correct way to return them is. They could go into the response headers via setResponseHeaders or the returned XML format could be changed to support properties and the header. Sadly this would likely break most existing clients.
> We'd like to use the REST API to enable some web clients to fully participate in a messaging system that is primarily Java based.
> If we can come to agreement on how we want to return properties then I'd be happy to code up a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira