[GitHub] [nifi] markap14 commented on a change in pull request #5291: NIFI-9036 - Add AWS MSK IAM support to Kafka processors

[GitBox <gi...@apache.org>]

markap14 commented on a change in pull request #5291:
URL: https://github.com/apache/nifi/pull/5291#discussion_r724428821



##########
File path: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/KafkaProcessorUtils.java
##########
@@ -183,6 +186,32 @@
             .addValidator(StandardValidators.NON_BLANK_VALIDATOR)
             .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
             .build();
+    static final PropertyDescriptor AWS_PROFILE_NAME = new PropertyDescriptor.Builder()
+            .name("aws.profilename")
+            .displayName("AWS Profile Name")
+            .description("The AWS Profile to consider when there are multiple profiles in the instance.")
+            .required(false)
+            .addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+            .build();
+    static final PropertyDescriptor AWS_ROLE_ARN = new PropertyDescriptor.Builder()
+            .name("aws.arn")
+            .displayName("AWS Role ARN")
+            .description("The awsRoleArn specifies the ARN for the IAM role the client should use.")
+            .required(false)
+            .addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+            .build();
+    static final PropertyDescriptor AWS_SESSION_NAME = new PropertyDescriptor.Builder()
+            .name("aws.session.name")
+            .displayName("AWS Role Session Name")
+            .description("specifies the session name that this particular client should use while assuming the IAM role. If the same IAM Role "
+                + "is used in multiple contexts, the session names can be used to differentiate between the different contexts. "
+                + "The awsRoleSessionName is optional")
+            .required(false)
+            .addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+            .build();

Review comment:
       Each of these Property Descriptors should indicate:
   ```
   .dependsOn(SASL_MECHANISM, SASL_MECHANISM_AWS_MSK_IAM)
   ```
   
   That way, these values are not shown in the UI if the SASL Mechanism is not set to SASL_MECHANISM_AWS_MSK_IAM. It also means that these can be made required, if it makes sense to do so. In that case, they will be required if and only if the SASL mechanism is set to IAM. Not sure if it makes sense to require them in that case or not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org