You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/10/13 18:05:41 UTC

[GitHub] Mogball opened a new pull request #3668: [Explore] Altered Slice Tag

Mogball opened a new pull request #3668: [Explore] Altered Slice Tag
URL: https://github.com/apache/incubator-superset/pull/3668
 
 
   Based on a suggesting by @mistercrunch in https://github.com/apache/incubator-superset/issues/3617, this PR implements an `AlteredSliceTag` which is displayed next to the slice title in the `explore` view when the current controls do not match the saved slice controls:
   
   <img width="242" alt="screen shot 2017-10-13 at 10 57 46 am" src="https://user-images.githubusercontent.com/15016832/31559452-82a42eca-b005-11e7-87e7-e72274a9c0ab.png">
   
   Users can click the tag to open a modal summarizing the differences:
   
   <img width="804" alt="screen shot 2017-10-13 at 10 59 48 am" src="https://user-images.githubusercontent.com/15016832/31559502-b43bc4b6-b005-11e7-91bf-aa07a8dc576b.png">
   
   Most importantly, exploring a slice from a dashboard with dashboard filters will show the slice as `altered` with the applied filters as differences.
   
   Also fixes https://github.com/apache/incubator-superset/issues/3616
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services