You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ha...@apache.org on 2013/07/05 10:04:07 UTC
svn commit: r1499927 -
/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Author: hansbak
Date: Fri Jul 5 08:04:07 2013
New Revision: 1499927
URL: http://svn.apache.org/r1499927
Log:
add screenlet to add accounting company screen
Modified:
ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Modified: ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml (original)
+++ ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml Fri Jul 5 08:04:07 2013
@@ -86,7 +86,9 @@ under the License.
<widgets>
<decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}">
<decorator-section name="body">
- <include-form name="AddCompany" location="component://accounting/widget/GlSetupForms.xml"/>
+ <screenlet title="${uiLabelMap.AccountingNewCompany}">
+ <include-form name="AddCompany" location="component://accounting/widget/GlSetupForms.xml"/>
+ </screenlet>
</decorator-section>
</decorator-screen>
</widgets>
Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Posted by Adrian Crum <ad...@sandglass-software.com>.
The screens used to be consistent until some committers decided to start
wrapping all screens in screenlets.
As we said, you are copying the wrong layout. If you want consistency,
then copy the right layout.
-Adrian
On 7/6/2013 1:16 AM, Hans Bakker wrote:
> Adrian, Scott,
>
> there is not a single screen that I am aware of in accounting, which
> is following this so called standard. (where is that documented anyway?)
>
> In my view, consistency is much more important, so i followed the
> current pattern used in accounting.
>
> Regards,
> Hans
>
> On 07/06/2013 01:58 AM, Adrian Crum wrote:
>> If you want to change the layout best practices, then that is fine -
>> but we need to discuss it first.
>>
>> The current best practices were agreed upon the last time we had this
>> discussion. If you would like to propose something else, then go
>> ahead. When we have a consensus, then we can update the best
>> practices page and rework the screens.
>>
>> -Adrian
>>
>> On 7/5/2013 12:55 PM, Hans Bakker wrote:
>>> I am sorry Adrian, this is not a pretty screen,
>>>
>>> https://localhost:8443/accounting/control/EditFixedAsset
>>>
>>> i prefer the screen with a screenlet as really many, many others. I
>>> would like to change your screen too :-)
>>>
>>> Regards,
>>> Hans
>>>
>>>
>>>
>>> On 07/05/2013 06:49 PM, Adrian Crum wrote:
>>>> Making screens consistent is a good idea, but please make them
>>>> consistent with GOOD layouts, not with BAD layouts. Please follow
>>>> the best practices.
>>>>
>>>> https://localhost:8443/accounting/control/EditFixedAsset
>>>>
>>>> -Adrian
>>>>
>>>> On 7/5/2013 12:46 PM, Hans Bakker wrote:
>>>>> to make the screen layout consistent to:
>>>>> https://localhost:8443/accounting/control/ListCompanies
>>>>> https://localhost:8443/accounting/control/globalGLSettings
>>>>> https://localhost:8443/accounting/control/editInvoiceItemType
>>>>> https://localhost:8443/accounting/control/editPaymentMethodType
>>>>> https://localhost:8443/accounting/control/FindGlobalGlAccount
>>>>>
>>>>> and many, many others.....
>>>>>
>>>>> Regards,
>>>>> Hans
>>>>>
>>>>> On 07/05/2013 06:24 PM, Adrian Crum wrote:
>>>>>> Please don't do this. Screenlets are used to divide sections of a
>>>>>> screen in a multi-purpose screen. This screen appears to have a
>>>>>> single purpose.
>>>>>>
>>>>>> https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices
>>>>>>
>>>>>>
>>>>>> -Adrian
>>>>>>
>>>>>> On 7/5/2013 9:04 AM, hansbak@apache.org wrote:
>>>>>>> Author: hansbak
>>>>>>> Date: Fri Jul 5 08:04:07 2013
>>>>>>> New Revision: 1499927
>>>>>>>
>>>>>>> URL: http://svn.apache.org/r1499927
>>>>>>> Log:
>>>>>>> add screenlet to add accounting company screen
>>>>>>>
>>>>>>> Modified:
>>>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>>>
>>>>>>> Modified:
>>>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>>> URL:
>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff
>>>>>>> ==============================================================================
>>>>>>>
>>>>>>> ---
>>>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>>> (original)
>>>>>>> +++
>>>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>>> Fri Jul 5 08:04:07 2013
>>>>>>> @@ -86,7 +86,9 @@ under the License.
>>>>>>> <widgets>
>>>>>>> <decorator-screen name="main-decorator"
>>>>>>> location="${parameters.mainDecoratorLocation}">
>>>>>>> <decorator-section name="body">
>>>>>>> - <include-form name="AddCompany"
>>>>>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>>>>>> + <screenlet
>>>>>>> title="${uiLabelMap.AccountingNewCompany}">
>>>>>>> + <include-form name="AddCompany"
>>>>>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>>>>>> + </screenlet>
>>>>>>> </decorator-section>
>>>>>>> </decorator-screen>
>>>>>>> </widgets>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Posted by Hans Bakker <ma...@antwebsystems.com>.
Before you jump in again: I stand corrected: only the fixed asset
function is using it, pretty inconsistent if you look to the rest of
accounting.
Regards,
Hans
On 07/06/2013 07:16 AM, Hans Bakker wrote:
> Adrian, Scott,
>
> there is not a single screen that I am aware of in accounting, which
> is following this so called standard. (where is that documented anyway?)
>
> In my view, consistency is much more important, so i followed the
> current pattern used in accounting.
>
> Regards,
> Hans
>
> On 07/06/2013 01:58 AM, Adrian Crum wrote:
>> If you want to change the layout best practices, then that is fine -
>> but we need to discuss it first.
>>
>> The current best practices were agreed upon the last time we had this
>> discussion. If you would like to propose something else, then go
>> ahead. When we have a consensus, then we can update the best
>> practices page and rework the screens.
>>
>> -Adrian
>>
>> On 7/5/2013 12:55 PM, Hans Bakker wrote:
>>> I am sorry Adrian, this is not a pretty screen,
>>>
>>> https://localhost:8443/accounting/control/EditFixedAsset
>>>
>>> i prefer the screen with a screenlet as really many, many others. I
>>> would like to change your screen too :-)
>>>
>>> Regards,
>>> Hans
>>>
>>>
>>>
>>> On 07/05/2013 06:49 PM, Adrian Crum wrote:
>>>> Making screens consistent is a good idea, but please make them
>>>> consistent with GOOD layouts, not with BAD layouts. Please follow
>>>> the best practices.
>>>>
>>>> https://localhost:8443/accounting/control/EditFixedAsset
>>>>
>>>> -Adrian
>>>>
>>>> On 7/5/2013 12:46 PM, Hans Bakker wrote:
>>>>> to make the screen layout consistent to:
>>>>> https://localhost:8443/accounting/control/ListCompanies
>>>>> https://localhost:8443/accounting/control/globalGLSettings
>>>>> https://localhost:8443/accounting/control/editInvoiceItemType
>>>>> https://localhost:8443/accounting/control/editPaymentMethodType
>>>>> https://localhost:8443/accounting/control/FindGlobalGlAccount
>>>>>
>>>>> and many, many others.....
>>>>>
>>>>> Regards,
>>>>> Hans
>>>>>
>>>>> On 07/05/2013 06:24 PM, Adrian Crum wrote:
>>>>>> Please don't do this. Screenlets are used to divide sections of a
>>>>>> screen in a multi-purpose screen. This screen appears to have a
>>>>>> single purpose.
>>>>>>
>>>>>> https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices
>>>>>>
>>>>>>
>>>>>> -Adrian
>>>>>>
>>>>>> On 7/5/2013 9:04 AM, hansbak@apache.org wrote:
>>>>>>> Author: hansbak
>>>>>>> Date: Fri Jul 5 08:04:07 2013
>>>>>>> New Revision: 1499927
>>>>>>>
>>>>>>> URL: http://svn.apache.org/r1499927
>>>>>>> Log:
>>>>>>> add screenlet to add accounting company screen
>>>>>>>
>>>>>>> Modified:
>>>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>>>
>>>>>>> Modified:
>>>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>>> URL:
>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff
>>>>>>> ==============================================================================
>>>>>>>
>>>>>>> ---
>>>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>>> (original)
>>>>>>> +++
>>>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>>> Fri Jul 5 08:04:07 2013
>>>>>>> @@ -86,7 +86,9 @@ under the License.
>>>>>>> <widgets>
>>>>>>> <decorator-screen name="main-decorator"
>>>>>>> location="${parameters.mainDecoratorLocation}">
>>>>>>> <decorator-section name="body">
>>>>>>> - <include-form name="AddCompany"
>>>>>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>>>>>> + <screenlet
>>>>>>> title="${uiLabelMap.AccountingNewCompany}">
>>>>>>> + <include-form name="AddCompany"
>>>>>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>>>>>> + </screenlet>
>>>>>>> </decorator-section>
>>>>>>> </decorator-screen>
>>>>>>> </widgets>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Posted by Hans Bakker <ma...@antwebsystems.com>.
Adrian, Scott,
there is not a single screen that I am aware of in accounting, which is
following this so called standard. (where is that documented anyway?)
In my view, consistency is much more important, so i followed the
current pattern used in accounting.
Regards,
Hans
On 07/06/2013 01:58 AM, Adrian Crum wrote:
> If you want to change the layout best practices, then that is fine -
> but we need to discuss it first.
>
> The current best practices were agreed upon the last time we had this
> discussion. If you would like to propose something else, then go
> ahead. When we have a consensus, then we can update the best practices
> page and rework the screens.
>
> -Adrian
>
> On 7/5/2013 12:55 PM, Hans Bakker wrote:
>> I am sorry Adrian, this is not a pretty screen,
>>
>> https://localhost:8443/accounting/control/EditFixedAsset
>>
>> i prefer the screen with a screenlet as really many, many others. I
>> would like to change your screen too :-)
>>
>> Regards,
>> Hans
>>
>>
>>
>> On 07/05/2013 06:49 PM, Adrian Crum wrote:
>>> Making screens consistent is a good idea, but please make them
>>> consistent with GOOD layouts, not with BAD layouts. Please follow
>>> the best practices.
>>>
>>> https://localhost:8443/accounting/control/EditFixedAsset
>>>
>>> -Adrian
>>>
>>> On 7/5/2013 12:46 PM, Hans Bakker wrote:
>>>> to make the screen layout consistent to:
>>>> https://localhost:8443/accounting/control/ListCompanies
>>>> https://localhost:8443/accounting/control/globalGLSettings
>>>> https://localhost:8443/accounting/control/editInvoiceItemType
>>>> https://localhost:8443/accounting/control/editPaymentMethodType
>>>> https://localhost:8443/accounting/control/FindGlobalGlAccount
>>>>
>>>> and many, many others.....
>>>>
>>>> Regards,
>>>> Hans
>>>>
>>>> On 07/05/2013 06:24 PM, Adrian Crum wrote:
>>>>> Please don't do this. Screenlets are used to divide sections of a
>>>>> screen in a multi-purpose screen. This screen appears to have a
>>>>> single purpose.
>>>>>
>>>>> https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices
>>>>>
>>>>>
>>>>> -Adrian
>>>>>
>>>>> On 7/5/2013 9:04 AM, hansbak@apache.org wrote:
>>>>>> Author: hansbak
>>>>>> Date: Fri Jul 5 08:04:07 2013
>>>>>> New Revision: 1499927
>>>>>>
>>>>>> URL: http://svn.apache.org/r1499927
>>>>>> Log:
>>>>>> add screenlet to add accounting company screen
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff
>>>>>> ==============================================================================
>>>>>>
>>>>>> --- ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>> (original)
>>>>>> +++ ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>> Fri Jul 5 08:04:07 2013
>>>>>> @@ -86,7 +86,9 @@ under the License.
>>>>>> <widgets>
>>>>>> <decorator-screen name="main-decorator"
>>>>>> location="${parameters.mainDecoratorLocation}">
>>>>>> <decorator-section name="body">
>>>>>> - <include-form name="AddCompany"
>>>>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>>>>> + <screenlet
>>>>>> title="${uiLabelMap.AccountingNewCompany}">
>>>>>> + <include-form name="AddCompany"
>>>>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>>>>> + </screenlet>
>>>>>> </decorator-section>
>>>>>> </decorator-screen>
>>>>>> </widgets>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Posted by Adrian Crum <ad...@sandglass-software.com>.
If you want to change the layout best practices, then that is fine - but
we need to discuss it first.
The current best practices were agreed upon the last time we had this
discussion. If you would like to propose something else, then go ahead.
When we have a consensus, then we can update the best practices page and
rework the screens.
-Adrian
On 7/5/2013 12:55 PM, Hans Bakker wrote:
> I am sorry Adrian, this is not a pretty screen,
>
> https://localhost:8443/accounting/control/EditFixedAsset
>
> i prefer the screen with a screenlet as really many, many others. I
> would like to change your screen too :-)
>
> Regards,
> Hans
>
>
>
> On 07/05/2013 06:49 PM, Adrian Crum wrote:
>> Making screens consistent is a good idea, but please make them
>> consistent with GOOD layouts, not with BAD layouts. Please follow the
>> best practices.
>>
>> https://localhost:8443/accounting/control/EditFixedAsset
>>
>> -Adrian
>>
>> On 7/5/2013 12:46 PM, Hans Bakker wrote:
>>> to make the screen layout consistent to:
>>> https://localhost:8443/accounting/control/ListCompanies
>>> https://localhost:8443/accounting/control/globalGLSettings
>>> https://localhost:8443/accounting/control/editInvoiceItemType
>>> https://localhost:8443/accounting/control/editPaymentMethodType
>>> https://localhost:8443/accounting/control/FindGlobalGlAccount
>>>
>>> and many, many others.....
>>>
>>> Regards,
>>> Hans
>>>
>>> On 07/05/2013 06:24 PM, Adrian Crum wrote:
>>>> Please don't do this. Screenlets are used to divide sections of a
>>>> screen in a multi-purpose screen. This screen appears to have a
>>>> single purpose.
>>>>
>>>> https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices
>>>>
>>>>
>>>> -Adrian
>>>>
>>>> On 7/5/2013 9:04 AM, hansbak@apache.org wrote:
>>>>> Author: hansbak
>>>>> Date: Fri Jul 5 08:04:07 2013
>>>>> New Revision: 1499927
>>>>>
>>>>> URL: http://svn.apache.org/r1499927
>>>>> Log:
>>>>> add screenlet to add accounting company screen
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff
>>>>> ==============================================================================
>>>>>
>>>>> --- ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>> (original)
>>>>> +++ ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>> Fri Jul 5 08:04:07 2013
>>>>> @@ -86,7 +86,9 @@ under the License.
>>>>> <widgets>
>>>>> <decorator-screen name="main-decorator"
>>>>> location="${parameters.mainDecoratorLocation}">
>>>>> <decorator-section name="body">
>>>>> - <include-form name="AddCompany"
>>>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>>>> + <screenlet
>>>>> title="${uiLabelMap.AccountingNewCompany}">
>>>>> + <include-form name="AddCompany"
>>>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>>>> + </screenlet>
>>>>> </decorator-section>
>>>>> </decorator-screen>
>>>>> </widgets>
>>>>>
>>>>>
>>>>
>>>
>>
>
Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Posted by Scott Gray <sc...@hotwaxmedia.com>.
Pretty is irrelevant Hans, it's about document structure. It's pointless wrapping everything in a screenlet or we may as well not even have the widget in the first place and have it embedded in the decorator instead. Using bad layouts as a justification for more of them is silly.
Regards
Scott
On 5/07/2013, at 11:55 PM, Hans Bakker wrote:
> I am sorry Adrian, this is not a pretty screen,
>
> https://localhost:8443/accounting/control/EditFixedAsset
>
> i prefer the screen with a screenlet as really many, many others. I would like to change your screen too :-)
>
> Regards,
> Hans
>
>
>
> On 07/05/2013 06:49 PM, Adrian Crum wrote:
>> Making screens consistent is a good idea, but please make them consistent with GOOD layouts, not with BAD layouts. Please follow the best practices.
>>
>> https://localhost:8443/accounting/control/EditFixedAsset
>>
>> -Adrian
>>
>> On 7/5/2013 12:46 PM, Hans Bakker wrote:
>>> to make the screen layout consistent to:
>>> https://localhost:8443/accounting/control/ListCompanies
>>> https://localhost:8443/accounting/control/globalGLSettings
>>> https://localhost:8443/accounting/control/editInvoiceItemType
>>> https://localhost:8443/accounting/control/editPaymentMethodType
>>> https://localhost:8443/accounting/control/FindGlobalGlAccount
>>>
>>> and many, many others.....
>>>
>>> Regards,
>>> Hans
>>>
>>> On 07/05/2013 06:24 PM, Adrian Crum wrote:
>>>> Please don't do this. Screenlets are used to divide sections of a screen in a multi-purpose screen. This screen appears to have a single purpose.
>>>>
>>>> https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices
>>>>
>>>> -Adrian
>>>>
>>>> On 7/5/2013 9:04 AM, hansbak@apache.org wrote:
>>>>> Author: hansbak
>>>>> Date: Fri Jul 5 08:04:07 2013
>>>>> New Revision: 1499927
>>>>>
>>>>> URL: http://svn.apache.org/r1499927
>>>>> Log:
>>>>> add screenlet to add accounting company screen
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>>
>>>>> Modified: ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff
>>>>> ==============================================================================
>>>>> --- ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml (original)
>>>>> +++ ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml Fri Jul 5 08:04:07 2013
>>>>> @@ -86,7 +86,9 @@ under the License.
>>>>> <widgets>
>>>>> <decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}">
>>>>> <decorator-section name="body">
>>>>> - <include-form name="AddCompany" location="component://accounting/widget/GlSetupForms.xml"/>
>>>>> + <screenlet title="${uiLabelMap.AccountingNewCompany}">
>>>>> + <include-form name="AddCompany" location="component://accounting/widget/GlSetupForms.xml"/>
>>>>> + </screenlet>
>>>>> </decorator-section>
>>>>> </decorator-screen>
>>>>> </widgets>
>>>>>
>>>>>
>>>>
>>>
>>
>
Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Posted by Hans Bakker <ma...@antwebsystems.com>.
I am sorry Adrian, this is not a pretty screen,
https://localhost:8443/accounting/control/EditFixedAsset
i prefer the screen with a screenlet as really many, many others. I
would like to change your screen too :-)
Regards,
Hans
On 07/05/2013 06:49 PM, Adrian Crum wrote:
> Making screens consistent is a good idea, but please make them
> consistent with GOOD layouts, not with BAD layouts. Please follow the
> best practices.
>
> https://localhost:8443/accounting/control/EditFixedAsset
>
> -Adrian
>
> On 7/5/2013 12:46 PM, Hans Bakker wrote:
>> to make the screen layout consistent to:
>> https://localhost:8443/accounting/control/ListCompanies
>> https://localhost:8443/accounting/control/globalGLSettings
>> https://localhost:8443/accounting/control/editInvoiceItemType
>> https://localhost:8443/accounting/control/editPaymentMethodType
>> https://localhost:8443/accounting/control/FindGlobalGlAccount
>>
>> and many, many others.....
>>
>> Regards,
>> Hans
>>
>> On 07/05/2013 06:24 PM, Adrian Crum wrote:
>>> Please don't do this. Screenlets are used to divide sections of a
>>> screen in a multi-purpose screen. This screen appears to have a
>>> single purpose.
>>>
>>> https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices
>>>
>>>
>>> -Adrian
>>>
>>> On 7/5/2013 9:04 AM, hansbak@apache.org wrote:
>>>> Author: hansbak
>>>> Date: Fri Jul 5 08:04:07 2013
>>>> New Revision: 1499927
>>>>
>>>> URL: http://svn.apache.org/r1499927
>>>> Log:
>>>> add screenlet to add accounting company screen
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff
>>>> ==============================================================================
>>>>
>>>> --- ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>> (original)
>>>> +++ ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>> Fri Jul 5 08:04:07 2013
>>>> @@ -86,7 +86,9 @@ under the License.
>>>> <widgets>
>>>> <decorator-screen name="main-decorator"
>>>> location="${parameters.mainDecoratorLocation}">
>>>> <decorator-section name="body">
>>>> - <include-form name="AddCompany"
>>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>>> + <screenlet
>>>> title="${uiLabelMap.AccountingNewCompany}">
>>>> + <include-form name="AddCompany"
>>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>>> + </screenlet>
>>>> </decorator-section>
>>>> </decorator-screen>
>>>> </widgets>
>>>>
>>>>
>>>
>>
>
Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Posted by Adrian Crum <ad...@sandglass-software.com>.
Making screens consistent is a good idea, but please make them
consistent with GOOD layouts, not with BAD layouts. Please follow the
best practices.
https://localhost:8443/accounting/control/EditFixedAsset
-Adrian
On 7/5/2013 12:46 PM, Hans Bakker wrote:
> to make the screen layout consistent to:
> https://localhost:8443/accounting/control/ListCompanies
> https://localhost:8443/accounting/control/globalGLSettings
> https://localhost:8443/accounting/control/editInvoiceItemType
> https://localhost:8443/accounting/control/editPaymentMethodType
> https://localhost:8443/accounting/control/FindGlobalGlAccount
>
> and many, many others.....
>
> Regards,
> Hans
>
> On 07/05/2013 06:24 PM, Adrian Crum wrote:
>> Please don't do this. Screenlets are used to divide sections of a
>> screen in a multi-purpose screen. This screen appears to have a
>> single purpose.
>>
>> https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices
>>
>>
>> -Adrian
>>
>> On 7/5/2013 9:04 AM, hansbak@apache.org wrote:
>>> Author: hansbak
>>> Date: Fri Jul 5 08:04:07 2013
>>> New Revision: 1499927
>>>
>>> URL: http://svn.apache.org/r1499927
>>> Log:
>>> add screenlet to add accounting company screen
>>>
>>> Modified:
>>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>>
>>> Modified: ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff
>>> ==============================================================================
>>>
>>> --- ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>> (original)
>>> +++ ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>> Fri Jul 5 08:04:07 2013
>>> @@ -86,7 +86,9 @@ under the License.
>>> <widgets>
>>> <decorator-screen name="main-decorator"
>>> location="${parameters.mainDecoratorLocation}">
>>> <decorator-section name="body">
>>> - <include-form name="AddCompany"
>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>> + <screenlet
>>> title="${uiLabelMap.AccountingNewCompany}">
>>> + <include-form name="AddCompany"
>>> location="component://accounting/widget/GlSetupForms.xml"/>
>>> + </screenlet>
>>> </decorator-section>
>>> </decorator-screen>
>>> </widgets>
>>>
>>>
>>
>
Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Posted by Hans Bakker <ma...@antwebsystems.com>.
to make the screen layout consistent to:
https://localhost:8443/accounting/control/ListCompanies
https://localhost:8443/accounting/control/globalGLSettings
https://localhost:8443/accounting/control/editInvoiceItemType
https://localhost:8443/accounting/control/editPaymentMethodType
https://localhost:8443/accounting/control/FindGlobalGlAccount
and many, many others.....
Regards,
Hans
On 07/05/2013 06:24 PM, Adrian Crum wrote:
> Please don't do this. Screenlets are used to divide sections of a
> screen in a multi-purpose screen. This screen appears to have a single
> purpose.
>
> https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices
>
>
> -Adrian
>
> On 7/5/2013 9:04 AM, hansbak@apache.org wrote:
>> Author: hansbak
>> Date: Fri Jul 5 08:04:07 2013
>> New Revision: 1499927
>>
>> URL: http://svn.apache.org/r1499927
>> Log:
>> add screenlet to add accounting company screen
>>
>> Modified:
>> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>>
>> Modified: ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff
>> ==============================================================================
>>
>> --- ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>> (original)
>> +++ ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml Fri
>> Jul 5 08:04:07 2013
>> @@ -86,7 +86,9 @@ under the License.
>> <widgets>
>> <decorator-screen name="main-decorator"
>> location="${parameters.mainDecoratorLocation}">
>> <decorator-section name="body">
>> - <include-form name="AddCompany"
>> location="component://accounting/widget/GlSetupForms.xml"/>
>> + <screenlet
>> title="${uiLabelMap.AccountingNewCompany}">
>> + <include-form name="AddCompany"
>> location="component://accounting/widget/GlSetupForms.xml"/>
>> + </screenlet>
>> </decorator-section>
>> </decorator-screen>
>> </widgets>
>>
>>
>
Re: svn commit: r1499927 - /ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Posted by Adrian Crum <ad...@sandglass-software.com>.
Please don't do this. Screenlets are used to divide sections of a screen
in a multi-purpose screen. This screen appears to have a single purpose.
https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices
-Adrian
On 7/5/2013 9:04 AM, hansbak@apache.org wrote:
> Author: hansbak
> Date: Fri Jul 5 08:04:07 2013
> New Revision: 1499927
>
> URL: http://svn.apache.org/r1499927
> Log:
> add screenlet to add accounting company screen
>
> Modified:
> ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
>
> Modified: ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml?rev=1499927&r1=1499926&r2=1499927&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml (original)
> +++ ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml Fri Jul 5 08:04:07 2013
> @@ -86,7 +86,9 @@ under the License.
> <widgets>
> <decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}">
> <decorator-section name="body">
> - <include-form name="AddCompany" location="component://accounting/widget/GlSetupForms.xml"/>
> + <screenlet title="${uiLabelMap.AccountingNewCompany}">
> + <include-form name="AddCompany" location="component://accounting/widget/GlSetupForms.xml"/>
> + </screenlet>
> </decorator-section>
> </decorator-screen>
> </widgets>
>
>