You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2022/04/19 14:25:27 UTC

[camel] branch main updated: camel-jbang - Only log downloaded JAR at INFO level if it was slow

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/main by this push:
     new 412be9057f7 camel-jbang - Only log downloaded JAR at INFO level if it was slow
412be9057f7 is described below

commit 412be9057f78e263d44e94e51d569c7261917a60
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Tue Apr 19 16:24:50 2022 +0200

    camel-jbang - Only log downloaded JAR at INFO level if it was slow
---
 .../main/java/org/apache/camel/main/DownloaderHelper.java   | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/DownloaderHelper.java b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/DownloaderHelper.java
index 29ac044e375..444df1fd94b 100644
--- a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/DownloaderHelper.java
+++ b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/DownloaderHelper.java
@@ -47,8 +47,17 @@ public final class DownloaderHelper {
 
         LOG.debug("Downloading dependency: {}:{}:{}", groupId, artifactId, version);
         Grape.grab(map);
-        LOG.info("Downloaded dependency: {}:{}:{} took: {}", groupId, artifactId, version,
-                TimeUtils.printDuration(watch.taken()));
+
+        // only report at INFO if downloading took > 1s because loading from cache is faster
+        // and then it is not downloaded over the internet
+        long taken = watch.taken();
+        String msg = "Downloaded dependency: " + groupId + ":" + artifactId + ":" + version + " took: "
+                     + TimeUtils.printDuration(taken);
+        if (taken < 1000) {
+            LOG.debug(msg);
+        } else {
+            LOG.debug(msg);
+        }
     }
 
     public static boolean alreadyOnClasspath(CamelContext camelContext, String artifactId, String version) {