You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/05/11 18:45:45 UTC

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog 

Hello Adar Dembo, Hao Hao,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10380

to review the following change.


Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................

KUDU-2191 (11/n): remove fallback logic from HmsCatalog

HmsCatalog was originally written with fallback logic that would
liberally correct HMS entries when possible. In particular, altering a
non-existent table entry would result in the HMS Catalog creating a new
table entry. These liberal corrections allowed the HMS catalog to
'upgrade' legacy Kudu tables to have HMS entries automatically upon any
kind of alteration, but in certain race conditions it could lead to a
single Kudu table having multiple HMS table entries with different
names.  This will be problematic down the line for other integrations
like Sentry, which rely on HMS metadata being canonical.

This commit removes this logic, which simplifies HmsCatalog, and removes
the need for a bunch of the tests which covered this fallback logic. As
a result, the metadata upgrade tool is going to need a special path
which allows it to alter Kudu tables without modifying the HMS. That
will be included in a follow up commit.

Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/integration-tests/master_hms-itest.cc
4 files changed, 47 insertions(+), 210 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/10380/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10380 )

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................

KUDU-2191 (11/n): remove fallback logic from HmsCatalog

HmsCatalog was originally written with fallback logic that would
liberally correct HMS entries when possible. In particular, altering a
non-existent table entry would result in the HMS Catalog creating a new
table entry. These liberal corrections allowed the HMS catalog to
'upgrade' legacy Kudu tables to have HMS entries automatically upon any
kind of alteration, but in certain race conditions[1] it could lead to a
single Kudu table having multiple HMS table entries with different
names. This will be problematic down the line for other integrations
like Sentry, which rely on HMS metadata being canonical.

This commit removes this logic, which simplifies HmsCatalog, and removes
the need for a bunch of the tests which covered this fallback logic. As
a result, the metadata upgrade tool is going to need a special path
which allows it to alter Kudu tables without modifying the HMS. That
will be included in a follow up commit.

[1]: consider the following operation sequence:

      - in Hive: ALTER TABLE a RENAME TO b
      - in Kudu: ALTER TABLE a RENAME TO c

  When handling the Kudu alter table, the 'a' table exists in the Kudu
  catalog, but not in the HMS. As a result the HmsCatalog creates a new
  table entry with name 'c'. At this point the HMS contains two table
  entries ('b' and 'c'), both representing the same Kudu table. This
  will cause problems for Sentry, for dropping the table, etc.

Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Reviewed-on: http://gerrit.cloudera.org:8080/10380
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/integration-tests/master_hms-itest.cc
4 files changed, 58 insertions(+), 216 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified
  Hao Hao: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10380 )

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10380/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10380/1//COMMIT_MSG@14
PS1, Line 14: but in certain race conditions
> Could you provide an example?
Done


http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc
File src/kudu/hms/hms_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc@147
PS1, Line 147:   RETURN_NOT_OK(ParseTableName(name, &hms_database, &hms_table));
> I guess you are making this change because we assume that for every table e
If parsing the table name fails, then the table must necessarily be a legacy table which is not in the HMS. We could return an OK status in this scenario, since we know there is nothing to drop from the HMS, however this would lead to inconsistent results based on the identifier.  For example, the table names 'nodb' and 'foo.b@r'. Both identifiers are Hive-incompatible, and thus indicate legacy tables, however the first will fail ParseTableName and the second will succeed.

I'm happy to put that into a comment if y'all think it would be useful, but I think in the long run it would be more confusing than illuminating.  All of the code-paths in this class are changing to not recover from failures (as well as assume tables are already HMS integrated), so it won't be strange that this particular failure isn't recovered.


http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc@153
PS1, Line 153:     return client->DropTable(hms_database, hms_table, env_ctx);
> Why not continue to treat a missing table as a non-error?
Similar to the previous issue, this class is now assuming all tables are HMS integrated.  Not recovering from this failure will be critical once the follow-up commit lands that serializes DropTable ops through the HMS.  If we recovered from that then the table wouldn't actually be dropped, since the notification log listener would never receive the event.



-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 14 May 2018 18:29:13 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10380 )

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 14 May 2018 22:31:55 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10380 )

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................


Patch Set 1:

Also, the failed test cases seem to be related.


-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 11 May 2018 21:18:32 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10380 )

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 14 May 2018 20:57:53 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10380 )

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc
File src/kudu/hms/hms_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc@153
PS1, Line 153:     return client->DropTable(hms_database, hms_table, env_ctx);
> > Similar to the previous issue, this class is now assuming all
Please ignore this empty comment. Sorry for any inconvenience.



-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 14 May 2018 19:26:53 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10380 )

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/10380/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10380/1//COMMIT_MSG@14
PS1, Line 14: but in certain race conditions
Could you provide an example?


http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc
File src/kudu/hms/hms_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc@147
PS1, Line 147:   RETURN_NOT_OK(ParseTableName(name, &hms_database, &hms_table));
Why this change?


http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc@153
PS1, Line 153:     return client->DropTable(hms_database, hms_table, env_ctx);
Why not continue to treat a missing table as a non-error?


http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc@171
PS1, Line 171: number
nice



-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 11 May 2018 19:08:54 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10380 )

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc
File src/kudu/hms/hms_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc@147
PS1, Line 147:   RETURN_NOT_OK(ParseTableName(name, &hms_database, &hms_table));
> Thanks a lot for the explanation. I think it may worth to document it in th
I've made this more explicit in the method docs for DropTable and AlterTable.



-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 14 May 2018 20:49:44 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10380

to look at the new patch set (#2).

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................

KUDU-2191 (11/n): remove fallback logic from HmsCatalog

HmsCatalog was originally written with fallback logic that would
liberally correct HMS entries when possible. In particular, altering a
non-existent table entry would result in the HMS Catalog creating a new
table entry. These liberal corrections allowed the HMS catalog to
'upgrade' legacy Kudu tables to have HMS entries automatically upon any
kind of alteration, but in certain race conditions[1] it could lead to a
single Kudu table having multiple HMS table entries with different
names. This will be problematic down the line for other integrations
like Sentry, which rely on HMS metadata being canonical.

This commit removes this logic, which simplifies HmsCatalog, and removes
the need for a bunch of the tests which covered this fallback logic. As
a result, the metadata upgrade tool is going to need a special path
which allows it to alter Kudu tables without modifying the HMS. That
will be included in a follow up commit.

[1]: consider the following operation sequence:

      - in Hive: ALTER TABLE a RENAME TO b
      - in Kudu: ALTER TABLE a RENAME TO c

  When handling the Kudu alter table, the 'a' table exists in the Kudu
  catalog, but not in the HMS. As a result the HmsCatalog creates a new
  table entry with name 'c'. At this point the HMS contains two table
  entries ('b' and 'c'), both representing the same Kudu table. This
  will cause problems for Sentry, for dropping the table, etc.

Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
---
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/integration-tests/master_hms-itest.cc
4 files changed, 58 insertions(+), 216 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/10380/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10380 )

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc
File src/kudu/hms/hms_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc@147
PS1, Line 147:   RETURN_NOT_OK(ParseTableName(name, &hms_database, &hms_table));
> If parsing the table name fails, then the table must necessarily be a legac
Thanks a lot for the explanation. I think it may worth to document it in the class level about the assumption of all tables are HMS integrated in this class.


http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc@153
PS1, Line 153:     return client->DropTable(hms_database, hms_table, env_ctx);
> Similar to the previous issue, this class is now assuming all
 > tables are HMS integrated.  Not recovering from this failure will
 > be critical once the follow-up commit lands that serializes
 > DropTable ops through the HMS.  If we recovered from that then the
 > table wouldn't actually be dropped, since the notification log
 > listener would never receive the event.



-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 14 May 2018 19:25:19 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2191 (11/n): remove fallback logic from HmsCatalog

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10380 )

Change subject: KUDU-2191 (11/n): remove fallback logic from HmsCatalog
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc
File src/kudu/hms/hms_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/10380/1/src/kudu/hms/hms_catalog.cc@147
PS1, Line 147:   RETURN_NOT_OK(ParseTableName(name, &hms_database, &hms_table));
> Why this change?
I guess you are making this change because we assume that for every table exist in Kudu, it should exist in the HMS as well when HMS integration is enabled? But would it be too strict for certain cases that there are missing tables in HMS and the user does want to drop the Kudu table? If not, would you mind adding a comment here?



-- 
To view, visit http://gerrit.cloudera.org:8080/10380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0753b1868b406c32e183896caa0427eedebdd8f7
Gerrit-Change-Number: 10380
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 11 May 2018 21:17:38 +0000
Gerrit-HasComments: Yes