[GitHub] [airflow] ashb commented on a change in pull request #13423: Add bash hook

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #13423:
URL: https://github.com/apache/airflow/pull/13423#discussion_r551361096



##########
File path: airflow/hooks/bash.py
##########
@@ -0,0 +1,88 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import os
+import signal
+from subprocess import PIPE, STDOUT, Popen
+from tempfile import TemporaryDirectory, gettempdir
+from typing import Dict, Optional
+
+from airflow import AirflowException
+from airflow.hooks.base import BaseHook
+
+
+class BashHook(BaseHook):

Review comment:
       So two observationsj:
   
   This hook has nothing to do with bash -- it doesn't run bash, it just runs a command.
   
   Secondly the main purpose of a Hook is to make use of a connection -- this doesn't do that either.
   
   So I like the idea of separation, but I'm not sure of the exact separation/code layout.
   
   One monent.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org